Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11344 - INSERT via HOTKEY returns to WPS (inconsistent!)

Attached to Project: Rockbox
Opened by Ryan Sawhill (ryran) - Tuesday, 01 June 2010, 12:12 GMT+2
Last edited by Alexander Levin (fml2) - Friday, 17 December 2010, 10:59 GMT+2
Task Type Bugs
Category Playlists
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Inconsistency:
HOTKEY_INSERT, HOTKEY_INSERT_SHUFFLED return you to WPS;
straight PLAYLIST_INSERT or PLAYLIST_INSERT_SHUFFLED keep you in tree

Reproduce:
on a track in filebrowser: hold_select > playlist > insert
track is added to your current playlist without taking you to WPS

set hotkey to insert
on a track in filebrowser: hotkey
track is added to your current playlist, but you're taken back to WPS

In attached patch, you can see how I got around this issue. I'm no expert though, and I wouldn't be surprised if this isn't the best way to go about it. Also odd that HK_INSERT & HK_INS_SHUFFLED have different ONPLAY ... what's the term here.. "returns"? I dunno. I'm just figuring things out as I go. :)

I'm on r26444.
This task depends upon

Closed by  Alexander Levin (fml2)
Friday, 17 December 2010, 10:59 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as r28847. Thanks!
Comment by Ryan Sawhill (ryran) - Tuesday, 01 June 2010, 12:14 GMT+2
aww BOO.
   hotkeyfix.patch (0.6 KiB) 
 apps/onplay.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment by Rafaël Carré (funman) - Saturday, 26 June 2010, 01:05 GMT+2
Can you come on irc and ping Blue_Dude about it ?
Comment by Boris Gjenero (dreamlayers) - Wednesday, 28 July 2010, 02:03 GMT+2
Resynched to r27589.

I feel this is a desirable patch, but not really a bug. The functionality still works as-is; I just find going back to the WPS less convenient. For me, the whole point of these hotkeys is making playlist creation easier. Usually when I am creating a playlist I add multiple files from the file browser. If I need to go from the WPS to the file browser every time, that makes the process slower and kind of annoying.
   hotkeyfix-r27589.patch (0.7 KiB) 
 apps/onplay.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Loading...