Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11345 - Change find_tag() to return the tag from the table and store a pointer to that in the element

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Tuesday, 01 June 2010, 13:25 GMT+2
Last edited by Michael Chicoine (mc2739) - Tuesday, 01 June 2010, 20:15 GMT+2
Task Type Patches
Category Utils
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.4
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch changes find_tag() to return the tag from the tag table and storing that in the tree element instead of just the name. This (or similar) is needed by the rockbox build so a second lookup isnt needed to get the enum value from the tag name.

   tag_args_in_element.diff (3.8 KiB) 
 parsetreenode.cpp |    5 +++--
 skin_debug.c      |    3 ++-
 skin_parser.c     |   12 +++++++-----
 tag_table.c       |    4 ++--
 skin_parser.h     |    2 +-
 tag_table.h       |    2 +-
 6 files changed, 16 insertions(+), 12 deletions(-)

This task depends upon

Closed by  Michael Chicoine (mc2739)
Tuesday, 01 June 2010, 20:15 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as r26448

Closed per request of Robert Bieber

Loading...