Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11351 - "Next Track" is not displayed with single audio+cue files

Attached to Project: Rockbox
Opened by Dave Cochrane (FLACtastic) - Friday, 04 June 2010, 17:24 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 06 June 2010, 08:29 GMT+2
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Sansa Fuze v2
daily build: r26534

When playing a single album file (e.g. FLAC or APE or WV) + CUE file, it plays fine, and it displays the current track (song) but it does not display "Next Track" - this is just blank.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 06 June 2010, 08:29 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  in r26611. no change for the wps playlist viewer yet though
Comment by Jonathan Gordon (jdgordon) - Sunday, 06 June 2010, 04:07 GMT+2
This is more of a feature request than a bug.
<technical babble>Because of the way cuesheets fiddle with the id3 info this isnt really doable. if someone were to have a look at cue_spoof_id3() specifically how it is used then this could happen. Basically for this to be done it would need get_id3_token() to do the cuesheet lookup instead of cue_spoof_id3() happening.
Once that is done then displaying the next track from the cuesheet tracks would be simple.</technobabble>

Comment by Jonathan Gordon (jdgordon) - Sunday, 06 June 2010, 04:47 GMT+2
test this patch :) will display the "next track" info from the cuesheets or the real next track if we are in the last cuesheet track

if this goes in there is a bit of work needed to make the wps playlist viewer use this also... easy though
   cuesheetnextrack.diff (5.9 KiB) 
 apps/gui/skin_engine/skin_tokens.c |   13 +++++++++
 apps/cuesheet.c                    |   50 +++++++++++++++++++++----------------
 apps/cuesheet.h                    |    6 ++--
 apps/playback.c                    |    2 -
 apps/mpeg.c                        |    1 
 apps/gui/wps.c                     |    1 
 6 files changed, 46 insertions(+), 27 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Sunday, 06 June 2010, 05:18 GMT+2
better version to make the playlist viewer easier to fix
   cuesheetnextrack.diff (5.7 KiB) 
 apps/gui/skin_engine/skin_tokens.c |    7 +++++
 apps/cuesheet.c                    |   51 +++++++++++++++++++++----------------
 apps/cuesheet.h                    |    6 ++--
 apps/playback.c                    |    2 -
 apps/mpeg.c                        |    1 
 apps/gui/wps.c                     |    1 
 6 files changed, 41 insertions(+), 27 deletions(-)

Loading...