Rockbox

Tasklist

FS#11368 - Viewport Font Color WPS Tags Don't Work

Attached to Project: Rockbox
Opened by Keith Perri (perrikwp) - Monday, 07 June 2010, 10:18 GMT
Last edited by Jonathan Gordon (jdgordon) - Monday, 07 June 2010, 10:47 GMT
Task Type Bugs
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

While using r26651, latest SVN at the time of writing this bug report. I believe there is a bug with the skin parser or theme loader. It is not changing the font color with respect to the viewport settings.

To test this, load one theme and then load another theme's wps file. The colors for the viewport should change depending on the colors specified in the wps file, but currently they don't.

Another clue is that the WPS uses the same font color as the menu font color and if you try to change the menu font color in Settings->Theme Settings->Colours->Foreground Colour nothing happens.

Please correct me if I'm wrong if this is the way it is meant to work, but it worked before the skin breaking changes were recently added.

Thanks!
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Monday, 07 June 2010, 10:47 GMT
Reason for closing:  Fixed
Additional comments about closing:  should be fixed in 26653
Comment by Keith Perri (perrikwp) - Monday, 07 June 2010, 10:25 GMT
Another thought, it could just be that my updated theme isn't correct. Here is the wps code just in case it is relevant: http://pastebin.com/UMKEux7Z

Loading...