Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11458 - Fix test_codec on low memory targets

Attached to Project: Rockbox
Opened by MichaelGiacomelli (saratoga) - Monday, 05 July 2010, 06:07 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Tuesday, 06 July 2010, 02:11 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

test_codec currently only works when the test file is smaller then the audio buffer. This makes it fail on low memory targets. This patch corrects that.
   test_codecv1.patch (4.3 KiB) 
 apps/plugins/test_codec.c |   87 +++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 74 insertions(+), 13 deletions(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Tuesday, 06 July 2010, 02:11 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r27303.
Comment by Rafaël Carré (funman) - Monday, 05 July 2010, 22:51 GMT+2
Clipv1 results: http://pastie.org/1031736

MP3 and aache are broken, it seems that decoding stops at the first rebuffer
Comment by MichaelGiacomelli (saratoga) - Monday, 05 July 2010, 23:06 GMT+2
Fixes MP3 for me (have to try AAC-HE yet).
   test_codecv2.patch (4.7 KiB) 
 apps/plugins/test_codec.c |   91 ++++++++++++++++++++++++++++++++++++++--------
 1 file changed, 76 insertions(+), 15 deletions(-)

Comment by MichaelGiacomelli (saratoga) - Monday, 05 July 2010, 23:43 GMT+2
AAC-He problems are due to AAC-He not working on low memory targets, so I think its not a bug in test_codec (or if it is we won't know until HE is fixed).
Comment by Rafaël Carré (funman) - Tuesday, 06 July 2010, 01:19 GMT+2
With v2: http://pastie.org/1031920

Looks ok, please commit we can still fix AAC-HE later

Loading...