Rockbox

Tasklist

FS#11486 - Bookmarks from tagcache don't work

Attached to Project: Rockbox
Opened by Marek Salaba (salaba) - Sunday, 18 July 2010, 18:15 GMT
Task Type Bugs
Category Database
Status Unconfirmed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No

Details

Hello.

I found that bookmarks which was automaticaly created (by the function Bookmark on Stop with set to Ask) from tagcache don't work. Problem is in missing path to file in bmark file. I made more test and now I attach bmark where first line/bookmark is from tagcache and second line/bookmark is from files browser.
Both are on approximately same time.

I testted on Sansa c250 and Sansa Fuse2 with Rockbox r27481-100718.

Can anybody from developers focused on it, please.

Much more thanks.
Salaba
This task depends upon

Comment by Magnus Holmgren (learman) - Sunday, 25 July 2010, 07:45 GMT
Bookmarks only works when starting playback from the file browser (see section 8.6 of the manual), so I'm a bit surprised a bookmark was created at all.
Comment by Marek Salaba (salaba) - Sunday, 22 August 2010, 08:42 GMT
Yes Magnus, you have truth. In section 8.6 is wrote :
Note: Bookmarking only works when tracks are launched from the file browser, and does not work for tracks launched via the database.
In addition, they do not work with dynamic playlists.
But when I starting playback from tagcache and after stop playback I get question for make bookmark and when I selct Yes, the wrong bookmark is created.

If can not correctly create bookmarks from tagcache, please programmers to fixed this incorrect creation.
Comment by Magnus Holmgren (learman) - Sunday, 22 August 2010, 15:36 GMT
Ah, the fact that you can create bookmarks on tagcache playlists is a regression from  FS#9660 . Seems like we need a "playlist created from tagcache" flag...
Comment by Marek Salaba (salaba) - Saturday, 15 January 2011, 13:36 GMT
You can then finally someone fix it!
When you do not bookmark from database, so let the choice / question does not.
Salaba
Comment by Marek Salaba (salaba) - Saturday, 19 February 2011, 19:13 GMT
I found this closed task  FS#5072  where only Alex Parker made this "I've added a note to the manual to reflect this in r24057" for solving this problem.
And in this task Jonathan Gordon good wrote this "to have any movement untill someone steps up to fix certain parts of the database (playlist generation and resume)...".

As I wrote up If can not correctly create bookmarks from tagcache, please programmers to fixed this incorrect creation - please block making bookmark from tagcache.

Loading...