Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11491 - Change to Coldfire part of libmad's synthesis filter

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Thursday, 22 July 2010, 07:51 GMT+2
Last edited by Andree Buschmann (Buschel) - Thursday, 22 July 2010, 20:58 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type Coldfire-based
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch moves the coldfire inline asm from synth_full() to 4 macros. Two of those macros are used twice within synth_full() with slightly modified calling parameters. I do not see a possiblity to re-use of the residual asm (for now).

Benefit of this change is much better readability of the synth_full() function. Furthermore we get the future possibility to go back to a single full_synth() function and only using CPU-dependent macros.

Remark to readability: For debugging purpose I have left the former inline asm commented in synth_full(). When this patch should be committed, I will remove this of course.

As I do not have any coldfire target, I can only compile for such target (it does for h300). I need a test on coldfire target to check, if the output compared to svn is still the same.
   libmad_cf_v02.patch (9.9 KiB) 
 apps/codecs/libmad/synth.c |  160 ++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 152 insertions(+), 8 deletions(-)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Thursday, 22 July 2010, 20:58 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Submitted with r27524
Comment by Andree Buschmann (Buschel) - Thursday, 22 July 2010, 20:27 GMT+2
Thanks to Nils Wallménius for debugging support with the first v02-patch.
   libmad_cf_v03.patch (16 KiB) 
 apps/codecs/libmad/synth.c |  308 ++++++++++++++++++++-------------------------
 1 file changed, 141 insertions(+), 167 deletions(-)

Comment by Andree Buschmann (Buschel) - Thursday, 22 July 2010, 20:41 GMT+2
Add "memory" to clobber list.
   libmad_cf_v04.patch (16 KiB) 
 apps/codecs/libmad/synth.c |  308 ++++++++++++++++++++-------------------------
 1 file changed, 141 insertions(+), 167 deletions(-)

Loading...