Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category User Interface → Simulator
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by mc2739 - 2010-08-07
Last edited by jdgordon - 2010-08-16

FS#11524 - Simulator crashes on startup

The simulator will crash on start when it loads a theme which contains an SBS that has a comment line prior to the %Vi line and additional viewport definitions after the %Vi line. The same theme loaded after the simulator has successfully started does not cause a crash and operates properly.

This failure started with r27665. A simulator built with r27664 does not crash.

Tested on e200 v1/v2 linux/win32 simulators. The linux version spits out a bunch of "SDL_WaitEvent() error" messages and then gets a Segmentation fault. The windows version just shuts down the window. If run with –debugwps, in each case the "Loading '/.rockbox/wps/foo.sbs'" message is displayed before the crash. The similar messages for
the WPS and FMS are not displayed.

This simple SBS will cause the crash:

#
%Vi(-,0,0,176,194,-)
%V(0,194,-,-,-)
TEST

Substituting the %V with %Vd/%Vl as below will also cause the same crash:

#
%Vi(-,0,0,176,194,-)
%Vd(a)
%Vl(a,0,194,-,-,-)
TEST

Removing the comment line in each case will allow the simulator to start properly.

Closed by  jdgordon
2010-08-16 12:53
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

r27829

mc2739 commented on 2010-08-09 03:07

Here is the test theme I used.

   test.zip (0.9 KiB)
mc2739 commented on 2010-08-09 12:26

Running the test.sbs file attached above through checkwps with -vvv option causes a seg fault. This failure also corresponds to the changes made in r27665. Checkwps built from r27664 does not fail.

./checkwps.sansae200 -vvv test.sbs
Checking test.sbs… WPS parsed OK

[ Viewport 

  [ Logical line on line 1

Segmentation fault

Removing the comment on line one and running checkwps again causes it to seg fault on the next comment line. If all comments are removed, checkwps runs properly.

freddyb commented on 2010-08-10 18:50

I'm not sure if this is right but it seems to fix the problem. I just added a check for NULL input in find_viewport().

   find_viewport_check_NULL.diff (0.5 KiB)

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing