Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11531 - wm8751/wm8750 driver rework

Attached to Project: Rockbox
Opened by Marcin Bukat (MarcinBukat) - Tuesday, 10 August 2010, 14:46 GMT+2
Last edited by Marcin Bukat (MarcinBukat) - Monday, 14 March 2011, 11:04 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch changes internal logic of the driver to allow easy utilization of all functions provided by those codecs. Besides it enables additional features:
- Bass cutoff filter characteristic setup (WM8751, WM8750)
- Treble cutoff filter characteristic setup (WM8751, WM8750)
- Enhance 3D (WM8750)
- ALC and NGAT when recording (WM8750)
- signal amplification in digital domain when recording in range -97dB ... +30dB (WM8750)
   wm8751_v01.diff (36.5 KiB) 
 b/apps/lang/english.lang          |   21 +
 b/firmware/drivers/audio/wm8751.c |  570 +++++++++++++++++++-------------------
 b/firmware/export/wm8751.h        |   38 ++
 3 files changed, 351 insertions(+), 278 deletions(-)

This task depends upon

Closed by  Marcin Bukat (MarcinBukat)
Monday, 14 March 2011, 11:04 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r29584
Comment by Frank Gevaerts (fg) - Tuesday, 10 August 2010, 22:05 GMT+2
Basic sound still works with this on gigabeat F. I don't know if the bass and treble cutoff settings work, you'll need someone with better ears for that
Comment by Marcin Bukat (MarcinBukat) - Wednesday, 11 August 2010, 18:36 GMT+2
Updated version
   wm8751_v02.diff (37.1 KiB) 
 b/apps/lang/english.lang          |   21 +
 b/firmware/drivers/audio/wm8751.c |  589 +++++++++++++++++++-------------------
 b/firmware/export/wm8751.h        |   38 ++
 3 files changed, 361 insertions(+), 287 deletions(-)

Comment by Marcin Bukat (MarcinBukat) - Wednesday, 11 August 2010, 20:44 GMT+2
The same as v02 but with updated all lang files
   wm8751_v03.diff (80.7 KiB) 
 b/apps/lang/bulgarian.lang            |   12 
 b/apps/lang/catala.lang               |   18 -
 b/apps/lang/chinese-simp.lang         |   18 -
 b/apps/lang/chinese-trad.lang         |   12 
 b/apps/lang/czech.lang                |   18 -
 b/apps/lang/dansk.lang                |   12 
 b/apps/lang/deutsch.lang              |   18 -
 b/apps/lang/english.lang              |   18 -
 b/apps/lang/espanol.lang              |   18 -
 b/apps/lang/finnish.lang              |   12 
 b/apps/lang/francais.lang             |   18 -
 b/apps/lang/greek.lang                |   12 
 b/apps/lang/hebrew.lang               |   12 
 b/apps/lang/italiano.lang             |   18 -
 b/apps/lang/japanese.lang             |   18 -
 b/apps/lang/korean.lang               |   12 
 b/apps/lang/lietuviu.lang             |   12 
 b/apps/lang/magyar.lang               |   12 
 b/apps/lang/nederlands.lang           |   18 -
 b/apps/lang/norsk-nynorsk.lang        |   12 
 b/apps/lang/norsk.lang                |   12 
 b/apps/lang/polski.lang               |   18 -
 b/apps/lang/portugues-brasileiro.lang |   18 -
 b/apps/lang/portugues.lang            |   12 
 b/apps/lang/romaneste.lang            |   12 
 b/apps/lang/russian.lang              |   12 
 b/apps/lang/slovak.lang               |   18 -
 b/apps/lang/slovenscina.lang          |   18 -
 b/apps/lang/srpski.lang               |   18 -
 b/apps/lang/svenska.lang              |   18 -
 b/apps/lang/tagalog.lang              |   12 
 b/apps/lang/thai.lang                 |   18 -
 b/apps/lang/turkce.lang               |   18 -
 b/apps/lang/ukrainian.lang            |   12 
 b/apps/lang/walon.lang                |   12 
 b/firmware/drivers/audio/wm8751.c     |  589 +++++++++++++++++-----------------
 b/firmware/export/wm8751.h            |   38 +-
 37 files changed, 604 insertions(+), 551 deletions(-)

Comment by amaury pouly (pamaury) - Thursday, 12 August 2010, 14:46 GMT+2
I tried the v02 and everything seems to work on M:Robe 100. Basic sound work, bass settings too. Treble does something but I don't know the expected result so I can't tell if it's correct or not. I didn't try to put the sound at maximim or minimum volume however.

Loading...