Rockbox

Further testing shows that the %pb() tag doesn’t affect how the %x() is displayed.
A viewport consisting of only the %x() tag fails to display the %x() image.

Example:

%V(0,0,-,8,2)
%x(a,pbbackground.bmp,32,0)
# will show nothing

%V(0,0,-,8,2)
%x(a,pbbackground.bmp,32,0)
%xd(a)
# shows the image.

Having tested various revisions, I found out that %x is no longer working exactly since r27787.

r27771, r27780, r27785 and r27786 all showed the picture with %x(a,a.bmp,0,0) just fine.

Workaround for now is to use %xl(a,a.bmp,0,0)%xd(a) instead.

As Andrew already commented, this has nothing to do with %pb. Just %x is broken. Sometimes the picture is drawn completely, sometimes incompletely (looks like noise in my case) and sometimes not at all.

are you absolutely sure it is 27787? I dont see anything in the diff which obviously breaks it :/

I tried on fuzev2 normal build.

Just checked again. Put r27786 on the player, selected the wps file with only
%V(0,95,-,16,1)
%x(a,a.bmp,0,0)
went to wps, image was shown. rebooted, continued playback, image was shown. rebooted again, continued playback, image was shown.

Now put r27787 with that same wps file on the player. Selected the wps file, went to wps, image was shown. rebooted, continued playback, no image.

I’ll have a look at the changes made in r27787 now. Maybe I can help you to narrow down where the problem comes from.

okay.. commenting out

1004 if (img→using_preloaded_icons)
1005 {
1006 img→loaded = true;
1007 list→token→type = SKIN_TOKEN_IMAGE_DISPLAY_LISTICON;
1008 }
1009 else
1010 {

and

1017 }

in r27787 makes %x working.

The problem is that the path “if (img→using_preloaded_icons)” is entered when it shouldn’t be… changing only line 1004 to if(0) is enough to prevent the problem from occuring.

very very wierd :/

umm… have you got it going in gdb there? is img→using_preloaded_icons true there? it shouldnt be

I added DEBUGF()s in the two paths there in skin_parser.c. But in the uisimulator the else path was chosen.

No I didn’t use any debugger. Can I even do it in the player without special equipment?

the sim runs fine in gdb, you cant use gdb on the actual target though

Too bad because the problem seems to happen only on the target after reboot :)

What could it be then? When I add
img→using_preloaded_icons = false;
before the line
if(img→using_preloaded_icons)
it works as well.

So yes, using_preloaded_icons is indeed true there!! And this only happens on boot, so maybe the simulator ‘boots’ differently?
But it does happen on multiple targets (see that the original poster used a clipplus).

AFAIK, the skin beffur isn’t cleared by zero, so i think there could be chance that the img→using_preloaded_icons is ture.
i think the bug is fixed by r28184.

Teruaki, seems you’re right, I’ve booted up r28220 many times now and the images with %x were indeed always drawn correctly.