Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11580 - Unify 32mb and 64mb ipod video builds

Attached to Project: Rockbox
Opened by Frank Gevaerts (fg) - Sunday, 29 August 2010, 15:47 GMT+2
Last edited by Frank Gevaerts (fg) - Tuesday, 31 August 2010, 21:07 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type iPod 5G
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This quick and dirty patch makes use of the fact that on a 32MB ipod video the RAM is mirrored in the address space, so the only thing actually needed to make a 64MB build not do nasty things on a 32MB board is adjusting audiobufend.

A quick test on my 32MB 5G with a 64MB build seems to work fine. A bit more testing is needed though, especially to see if a 64MB board uses all available RAM.

Also, firmware/target/arm/thread-pp.c and firmware/drivers/ata.c seem to do something different on 64MB builds. I don't know what should be done with those.

This *isn't* ready for commit yet. it probably doesn't even compile for most targets
   ipodvideo-unify.diff (1.2 KiB) 
 apps/main.c                      |    7 +++++++
 firmware/export/buffer.h         |    3 ++-
 firmware/target/arm/ipod/app.lds |    2 +-
 3 files changed, 10 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Frank Gevaerts (fg)
Tuesday, 31 August 2010, 21:07 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as r27960
Comment by Frank Gevaerts (fg) - Sunday, 29 August 2010, 17:16 GMT+2
Slightly improved version. Functionally exactly the same, but this one doesn't break other builds. It also sets the default memory amount in configure to 64.
   ipodvideo-unify_v2.diff (1.7 KiB) 
 tools/configure                  |    1 +
 apps/main.c                      |    7 +++++++
 firmware/export/buffer.h         |    5 +++++
 firmware/target/arm/ipod/app.lds |    4 ++++
 4 files changed, 17 insertions(+)

Comment by Frank Gevaerts (fg) - Sunday, 29 August 2010, 23:05 GMT+2
This version also handles the different current measurements in debug_menu.c and unifies the BATTERY_CAPACITY settings.

We might want to set BATTERY_CAPACITY_DEFAULT differently depending on detected RAM. I'm not sure of how to do that cleanly, and I'm not convinced we actually want that (due to boards being routinely swapped by repair centres and refurbishers). Apart from that, I think this patch is complete.
   ipodvideo-unify_v3.diff (3.8 KiB) 
 tools/configure                    |    1 +
 apps/debug_menu.c                  |   10 ++++------
 apps/main.c                        |    7 +++++++
 firmware/export/buffer.h           |    5 +++++
 firmware/export/config/ipodvideo.h |   13 ++++---------
 firmware/target/arm/ipod/app.lds   |    4 ++++
 6 files changed, 25 insertions(+), 15 deletions(-)

Comment by Frank Gevaerts (fg) - Sunday, 29 August 2010, 23:21 GMT+2
Final patch for the day: this one resolves the last remaining issue using the best solution for all thorny issues: document it in the manual.

I think this is ready for commit, assuming people don't find unexpected problems.
   ipodvideo-unify_v4.diff (5.1 KiB) 
 tools/configure                             |    1 +
 apps/debug_menu.c                           |   10 ++++------
 apps/main.c                                 |    7 +++++++
 firmware/export/buffer.h                    |    5 +++++
 firmware/export/config/ipodvideo.h          |   13 ++++---------
 firmware/target/arm/ipod/app.lds            |    4 ++++
 manual/configure_rockbox/system_options.tex |    6 +++++-
 7 files changed, 30 insertions(+), 16 deletions(-)

Loading...