Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11611 - Build with -std=gnu99

Attached to Project: Rockbox
Opened by Rafaël Carré (funman) - Tuesday, 07 September 2010, 10:39 GMT+2
Last edited by Rafaël Carré (funman) - Tuesday, 07 September 2010, 16:21 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Use -std=gnu99 instead of default gnu89 to allow the use of some additional C99 constructs, like for(int i=0; i<n; i++)

Remove inline keyword from some inline non static functions
Add static to some other

Modify pitch_detector to not use a struct

Builds & runs without warnings for Clip+
   gnu99.diff (5.6 KiB) 
 b/apps/plugins/doom/i_video.c        |    4 +-
 b/apps/plugins/lib/buflib.h          |    7 -----
 b/apps/plugins/midi/sequencer.c      |    2 -
 b/apps/plugins/pitch_detector.c      |   48 +++++++++++++++--------------------
 b/apps/plugins/rockboy/rockmacros.h  |    2 -
 b/apps/plugins/rockboy/sys_rockbox.c |    2 -
 b/tools/configure                    |    2 -
 7 files changed, 28 insertions(+), 39 deletions(-)

This task depends upon

Closed by  Rafaël Carré (funman)
Tuesday, 07 September 2010, 16:21 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r28021
Comment by Rafaël Carré (funman) - Tuesday, 07 September 2010, 16:13 GMT+2
committed fixes for plugins/, now only tools/configure remains

Loading...