FS#11632 - (rockboy) Some fixes and improvements
Opened by Michael Stummvoll (Stummi) - Saturday, 18 September 2010, 21:31 GMT
Last edited by Teruaki Kawashima (teru) - Thursday, 11 November 2010, 12:10 GMT
Hello again RB-Community :)
In last days I worked a lot with rockboy (assuming, playing pokemon blue edition is "working" *g*), and meanwhile I found some things that I like see to change/fixed there. This day a had some time so I decided to change rockboy a little.
- I added a playback-control at the menu. Primary to change the ingame volume at rockboy. In some cases it should also be possible to play music while running rockboy, but on my player (sansa fuze v2), rockboy crashes then because there is not enought memory. Maybe somebody finds a way to catch this and makes something, that only shows the playback-menu on players, where both - gnuboy and music playing - is possible on the same time and where not only a volume control without playback control.
- 5 slots to storage savegames are a little bit few for me, because, I am somebody, who likes use multiple gamefiles while playing. I changed the count of storage places to 20. I also "fixed" the coding style a little bit on this place, so that the number of slots is defined in a variable first and not calculated with the array later. (While writing this, I got a better idea: Why not show n+1 storage places, where n is the number of savegames, which already exist? Maybe I will try to implement this sometime)
- On overriding an existing savegame, there is the name of the old savegame presetted now. "Typing" the name every times saving was a little bit anoying for me
- When the name input for the savegame is canceled by user, the game won't get saved now. Afore an existing savegame gots overrided, even if I canceled the input
Patch based on the current svn-trunk-directory (r28107) is attached.
Thursday, 11 November 2010, 12:10 GMT
Reason for closing: Accepted
Additional comments about closing: Committed as r28554 and r28557. thanks.