Rockbox

Tasklist

FS#11634 - settings_load_config() calls config_save()

Attached to Project: Rockbox
Opened by Marcin Bukat (MarcinBukat) - Monday, 20 September 2010, 07:37 GMT
Last edited by Marcin Bukat (MarcinBukat) - Monday, 20 September 2010, 13:42 GMT
Task Type Bugs
Category Settings
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I found accidentally that settings_load_config() which is called at startup of the rb calls config_save(). This means that config file is rewiriten on every system startup. This can impact flash wear.

look at apps/settings.c:370
This task depends upon

Closed by  Marcin Bukat (MarcinBukat)
Monday, 20 September 2010, 13:42 GMT
Reason for closing:  Accepted
Additional comments about closing:  commited as r28120
Comment by Rafaël Carré (funman) - Monday, 20 September 2010, 07:57 GMT
Looks like it was added in r2479 for equalizers, and kept in r4772
Comment by Marcin Bukat (MarcinBukat) - Monday, 20 September 2010, 08:49 GMT
http://svn.rockbox.org/viewvc.cgi/trunk/apps/settings.c?view=diff&r1=12141&r2=12142

For me it looks like it was introduced in r12142 and never touched from then.
Comment by Marcin Bukat (MarcinBukat) - Monday, 20 September 2010, 09:12 GMT
Right this line was added in r2479 and later there ware code refactorings.
Comment by Marcin Bukat (MarcinBukat) - Monday, 20 September 2010, 12:15 GMT
I poked around and for me this call is simply not needed any more. Here is the patch that removes it.

Loading...