Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11644 - Playlist isn't loaded after reboot if it had ended

Attached to Project: Rockbox
Opened by Frank Gevaerts (fg) - Sunday, 26 September 2010, 22:43 GMT+2
Last edited by Frank Gevaerts (fg) - Tuesday, 24 January 2012, 23:16 GMT+2
Task Type Patches
Category Playlists
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The current playlist isn't loaded after reboot if it had ended. This makes things like "View Current Playlist" and "Save Current Playlist" behave differently after the end of a playlist if the player is rebooted. I think all such inconsistencies shoud be removed.

Note that with e.g. in-car use, the user may not even realise whether the DAP was rebooted or not, since it will power up automatically.

This patch changes that, so the current playlist is *always* reloaded.

Please review, I'm not a playback/playlist expert
   resume.diff (1 KiB) 
 apps/playlist_viewer.c |    2 +-
 apps/playback.c        |    4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Frank Gevaerts (fg)
Tuesday, 24 January 2012, 23:16 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  In current code the playlist viewer isn't accessible any more after the playlist ends, which means that the entire issue is moot.
Comment by Rosso Maltese (asettico) - Monday, 15 November 2010, 17:08 GMT+2
I can't see the difference in behaviour between this and FS#10343 or, at least, I see this one as a subset of that one.
Comment by sideral (sideral) - Tuesday, 05 July 2011, 15:32 GMT+2
assetico, the two patches are completely orthogonal, AFAIU. This patch restores a completed playlist after a reboot so that it can be inspected with the playlist editor, whereas FS#10343 allows restarting a completed playlist using the Resume playback function in the main menu instead of showing the "nothing to resume" splash.
Comment by Rosso Maltese (asettico) - Tuesday, 05 July 2011, 15:45 GMT+2
OK, now is more clear.
When I read "restore" I understand "load and play".
Thanks for the precise information.
Comment by Rosso Maltese (asettico) - Friday, 22 July 2011, 14:46 GMT+2
Sync to r30189.
   11644-playlists-Playlist_is_not_loaded_after_rebo... (0.9 KiB) 
 apps/playlist_viewer.c |    2 +-
 apps/playback.c        |    4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

Comment by Hayden Pearce (St.) - Friday, 05 August 2011, 03:33 GMT+2
Committed in r30226 and later reverted in r30232 due to this bug:

With this patch applied, dynamic playlists aren't blown away when inserting (a) track(s) with playback stopped. This makes it impossible to clear the dynamic playlist as all inserted tracks are appended to the current list instead of starting anew.

Recipe:

With this patch applied, insert some tracks into a dynamic playlist.
Stop playback.
Insert some tracks either from the Database or Filebrowser, these tracks are appended to the previous stopped dynamic playlist instead of starting a new dynamic playlist.


[St.]
Comment by Michael Sevakis (MikeS) - Tuesday, 24 January 2012, 21:54 GMT+2
What current playlist? There is no current playlist. After it ends, it's done; that's it. Seems like something conceptually distinct from a "current playlist" in a "now playing" sense.
Comment by Frank Gevaerts (fg) - Tuesday, 24 January 2012, 22:03 GMT+2
If you don't reboot, there is still something there, and the UI calls it the current playlist.
Comment by Michael Sevakis (MikeS) - Tuesday, 24 January 2012, 22:59 GMT+2
Menu items seem to be gone now.

Anyway, I'd either consider "end of playlist" to rid the system of the current playlist or always retain the previous one, either in memory or in persistent storage. If marked as completed, playlist edit commands should clear it properly, or always give a set of options. Appearance of "Erase dynamic playlist?" isn't even consistent between using directories and the database.

Loading...