Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11663 - Patch: iPod Nano 2G Bootloader: Boot OF if MENU button is held

Attached to Project: Rockbox
Opened by Michael Sparmann (TheSeven) - Saturday, 09 October 2010, 19:39 GMT+2
Last edited by Michael Sparmann (TheSeven) - Sunday, 10 October 2010, 22:52 GMT+2
Task Type Patches
Category Bootloader
Status Closed
Assigned To No-one
Player Type iPod Nano 2G
Severity Low
Priority High
Reported Version Daily build (which?)
Due in Version Next release
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch makes the iPod Nano 2G bootloader respond to the MENU button like the other iPod bootloaders do.

I'd like to have this included before Rockbox 3.7, if possible.

This needs testing on both the Nano 2G and other iPod generations, as I've touched the generic iPod clickwheel driver.
   nano2g-bootloader-menu-of.patch (4.6 KiB) 
 bootloader/ipodnano2g.c                      |    8 --
 firmware/target/arm/ipod/button-clickwheel.c |   74 +++++++++++++++++++++------
 2 files changed, 61 insertions(+), 21 deletions(-)

This task depends upon

Closed by  Michael Sparmann (TheSeven)
Sunday, 10 October 2010, 22:52 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Committed as r28237
Comment by Michael Sparmann (TheSeven) - Saturday, 09 October 2010, 20:01 GMT+2
Small fix for a big problem: Don't wait for the clickwheel to respond after releasing the hold switch, as this code might be called from a tick task, which doesn't like wakeup_wait.
   nano2g-bootloader-menu-of.patch (4.6 KiB) 
 bootloader/ipodnano2g.c                      |    8 --
 firmware/target/arm/ipod/button-clickwheel.c |   74 +++++++++++++++++++++------
 2 files changed, 61 insertions(+), 21 deletions(-)

Loading...