Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11686 - Kinetic list scrolling for touchscreen

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Tuesday, 19 October 2010, 12:03 GMT+2
Last edited by Thomas Martitz (kugel.) - Sunday, 31 October 2010, 23:14 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To Thomas Martitz (kugel.)
Player Type Another
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Future release
Due Date Undecided
Percent Complete 100%
Private No

Details

This adds kinetic list scrolling to touchscreen targets and RaaA, like all other OSes on touchscreens have. It's only enabled in the absolute point mode, so for non-touchscreen and in grid mode nothing changes.

I would like to see comments from cowond2 and onda users to see how it performs there. Other comments are appreciated as well too of course.

   kinetic_scroll-1.patch (21 KiB) 
 b/apps/gui/bitmap/list.c   |  275 +++++++++++++++++++++++++++++++++++++--------
 b/apps/gui/list.c          |   79 +++++++-----
 b/firmware/export/config.h |    6 
 3 files changed, 281 insertions(+), 79 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Sunday, 31 October 2010, 23:14 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  r28408
Comment by Jonathan Gordon (jdgordon) - Tuesday, 19 October 2010, 12:30 GMT+2
Is it possible to pull the swipe/gesture handling out into the button driver maybe? It would be really cool if it could be added in such a way that any screen could do this (even just up/down/left/right), obvious use would be in the wps for volume, or track skipping...
Comment by Thomas Martitz (kugel.) - Tuesday, 19 October 2010, 12:34 GMT+2
Neither of those sound compelling to me (and I've not seen those anywhere in other systems). Volume swiping is even potentially very dangerious.

But I once thought about it and I'm not sure if it can be moved out in a sensible way. The callbacks and setup and everything is pretty much tied to the list, so I'm unsure if it can be done in a generic way.
Comment by Giovanni Zilli (Giova) - Tuesday, 19 October 2010, 13:13 GMT+2
Just tested this patch on my Onda and it works pretty good but I've found that the two keys in sbs for moving trough the list up and down do not work (%T(0,0,80,50,prev) and %T(160,0,80,50,next))
Comment by Thomas Martitz (kugel.) - Tuesday, 19 October 2010, 14:21 GMT+2
I believe that was never supposed to work, so I'm not very afraid of breaking it. but I don't actually know why it would break.
Comment by Thomas Martitz (kugel.) - Tuesday, 26 October 2010, 02:16 GMT+2
a few bug fixes, e.g. it's possible to control with the dpad again.
   kinetic_scroll-2.patch (20.2 KiB) 
 b/apps/gui/bitmap/list.c   |  299 +++++++++++++++++++++++++++++++++++++--------
 b/apps/gui/list.c          |   39 +++--
 b/apps/gui/list.h          |    4 
 b/firmware/export/config.h |    6 
 4 files changed, 281 insertions(+), 67 deletions(-)

Loading...