Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11714 - tea5767 tuner detection

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Tuesday, 02 November 2010, 20:35 GMT+2
Last edited by Bertrik Sikken (bertrik) - Friday, 05 November 2010, 18:05 GMT+2
Task Type Patches
Category FM Tuner
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Currently the TEA5767 tuner driver does not support detection of the presence of the tuner chip, it simply assumes that it's always present. For some targets (HDD16x0 / HDD63x0 for example) this means that the radio can be "detected" even when not present.

This patch adds detection support for the tea5767. Detection is done by looking if there is an i2c device responding at all during initialisation and by checking the chipid field in the data read back from the tuner (should be 0).

If you have a target with a tea5767 tuner chip (see http://www.rockbox.org/wiki/FmTunerHardware#TEA5767), please try if the radio is still detected.
   tea5767_detect.patch (2 KiB) 
 firmware/export/tea5767.h        |    1 +
 firmware/drivers/tuner/tea5767.c |   21 ++++++++++++++++++++-
 firmware/tuner.c                 |    3 ++-
 3 files changed, 23 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Bertrik Sikken (bertrik)
Friday, 05 November 2010, 18:05 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Variant of last patch committed as SVN r28493.
Comment by Bertrik Sikken (bertrik) - Wednesday, 03 November 2010, 00:04 GMT+2
Updated patch:
* considers bit 0 to also be part of the chip id, the datasheet says this should always be 0
* pre-init the i2c read buffer with a 0xFF value so it will NOT be recognised as a tea5767 in case fmradio_i2c_read fails silently (it seems to do so on PP targets)

Hopefully this improves detection.
   tea5767_detect_v2.patch (2.1 KiB) 
 firmware/export/tea5767.h        |    1 +
 firmware/drivers/tuner/tea5767.c |   24 +++++++++++++++++++++++-
 firmware/tuner.c                 |    3 ++-
 3 files changed, 26 insertions(+), 2 deletions(-)

Comment by Robert Menes (RMenes379) - Wednesday, 03 November 2010, 13:33 GMT+2
Tested and works on my GoGear HDD6330.
Comment by Alex Parker (BigBambi) - Thursday, 04 November 2010, 21:04 GMT+2
H100 still thinks it has a radio with the batch :)
Comment by Szymon Dziok (b0hoon) - Thursday, 04 November 2010, 22:52 GMT+2
It works now for the PP I2C target (Philips HDD6320). I suppose it's because of considering bit 0 as a part of chip ID (readouts were 01 01 01 '01' 2C or 02 02 02 '02' 2C before).
Edit: Readouts are really random - fourth byte can be: 0x01, 0x02, 0xA7, 0xE7, but it is good enough.
Comment by Bertrik Sikken (bertrik) - Friday, 05 November 2010, 08:34 GMT+2
Thanks all for testing! I think this can be committed soon.

Curiously, all read values being the same (as seen by Szymon in some cases) is one of the methods the linux tea5767 driver uses to exclude the presence of the tea5767.

Loading...