Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11729 - AS3525/AS3525v2: remove unneeded I2SIN clock configuration

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Saturday, 06 November 2010, 10:06 GMT+2
Last edited by Bertrik Sikken (bertrik) - Tuesday, 09 November 2010, 22:54 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.6
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Currently the i2s (audio transport bus) has two clocks enabled, one for playback (i2sout) and one for recording (i2sin). It looks like we really need to configure only one of these, the i2sout clock. Recording is already configured to use the same clock (for details, see bit 8-9 in I2SIN_CONTROL).

This patch removes the unnecessary clock setup. This stops the i2sin clock from being generated, possibly even saving a little power. Also this simplifies the source code a bit.

To test this patch, try to alternate between recording and playback at various rates and see if they still work as expected.
   cgu_audio.patch (1.3 KiB) 
 firmware/target/arm/as3525/pcm-as3525.c |   11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

This task depends upon

Closed by  Bertrik Sikken (bertrik)
Tuesday, 09 November 2010, 22:54 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in SVN r28541

Loading...