- Status Closed
- Percent Complete
- Task Type Patches
- Category Plugins
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.7.1
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Opened by Self-Perfection - 2010-12-08
Last edited by saratoga - 2010-12-14
FS#11799 - Less disk activity patch for text viewer plugin
Current text viewer is very greedy for disk accesses. This is very annoying on HDD based players. For example, I’ve expirienced more 5 seconds pauses after “quit” command. This patch changes how saving preferences happens, so in most cases quiting text viewer plugin on HDD based player would be instant.
Fixed:
- tv_save_settings() were called twice upon exiting doubling all disk activity
- if tv_file.dat already had record for current file when preferences were saved tv_file.dat grew one record of garbage
Changed:
- Much more efficient code for saving preferences. Do not dawdle with temporary tv_file.tmp if this text is opened for the first time or there were no bookmark adding/removals since text were opened.
- Saving settings on exit only if preferences or bookmarks were changed since plugin start or text were scrolled. On devices with HAVE_DISK_STORAGE defined scrolling is ignored.
2010-12-14 21:34
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Committed in r28833.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task