This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#11835 - %Lt tag does not work
Attached to Project:
Rockbox
Opened by Leo Witt (some-xtc) - Friday, 24 December 2010, 16:16 GMT+2
Last edited by Teruaki Kawashima (teru) - Saturday, 15 January 2011, 12:45 GMT+2
Opened by Leo Witt (some-xtc) - Friday, 24 December 2010, 16:16 GMT+2
Last edited by Teruaki Kawashima (teru) - Saturday, 15 January 2011, 12:45 GMT+2
|
DetailsVersion: r28880
Hello, the %Lt tag does not work on the m:robe500. Tested with simulator too. |
This task depends upon
Closed by Teruaki Kawashima (teru)
Saturday, 15 January 2011, 12:45 GMT+2
Reason for closing: Fixed
Additional comments about closing: Fixed in r29058.
Saturday, 15 January 2011, 12:45 GMT+2
Reason for closing: Fixed
Additional comments about closing: Fixed in r29058.
I have several themes I have developed using this tag in the current build and all is well.
Attach the theme, and I'll have a look at it (or someone else will) when I get a chance.
[St.]
my exapmle is very simple and I use this tag with a conditional, like it is described in the wiki.
The code you have here is the same as: "If there's a List Title, display it" which coupled with the positioning you've chosen adds up to "Do absolutely nothing different at all when compared to default behaviour".
What is the effect you're trying to achieve, and what is it you're getting instead?
[St.]
http://themes.rockbox.org/index.php?themeid=1067&target=cowond2
But I get instead: nothing.
Am I wrong?
with
%?Lt<cake|cheese>
I get "cheese" (the hole time) on the m:robe
e.g %?Lt<no title|%Lt>
a picture is worth a thousand words:
(The following code is used on both simulator builds)
%wd
%V(0,0,320,30,1)%Vf(000000)%Vb(00eaff)
%?Lt<%Lt|cheese>
%Vi(-,10,40,300,100,1)%Vf(00eaff)%Vb(000000)
I hope, you understand my concern now.
Thanks!
All you need to do (and I know it looks fucking weird but I assure you it works) is:
%?Lt<>
Loosely translated: "If there's a list title (which is always true afaik), do nothing".
If you *do* want the title bar to display, then:
%?Lt<%Lt>
Will work fine.
all I want is to *move* the title bar to an other position, like on the terminal theme for the d2.
Teru,
it's a pitty, but I can't build rockbox on my own...
Ok, that's fine...easy.
To do this, we'll need at least two viewports...but we know this much already.
Firstly, we'll want the viewport that houses our list title-bar (lets assume the screen is 100x100px):
%V(0,0,100,20,1)%Vf(000000)%Vb(FFFFFF)
%ac%?Lt<%Lt>
Then, we want the rest of it to be the UI viewport, and we don't want either to overlap so:
%Vi(-,0,20,100,80,1)%Vf(FFFFFF)%Vb(000000)
It gets more interesting if you want to display the list title-bar icon, but you haven't yet mentioned wanting to do so,
so I'll leave that for now.
This works as expected on my end.
Teru,
What does your patch actually fix? As far as I'm concerned, it is working fine.
Just some confusion as to how the tag should be used I think.
When %?Lt condition is used, the list title-bar is not drawn in the UI viewport.
-To display the title-bar elsewhere, another viewport is defined and "%?Lt<%Lt>" is used.
-To remove the title-bar from display in the UI viewport, you can do "%?Lt<>" (if there's a title, do nothing).
I never find the need for a "false" case in the %?Lt condition, as I don't think it would ever be true.
I'm pretty sure that all screens have a list title, no?
thanks for your help, but do you already tested this with mr500-sim ?
Check it, and you will see ;-)
This is obviously a bug and not a wrong usage of the tag.
almost all screens using list seems to have title but there are screens not using list. those do not have list titles and the "false" case might be used in such case. e.g. quick screen.
Can you actually post the code you're using please?
[St.]