Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11856 - Set of ogg vorbis files will not play

Attached to Project: Rockbox
Opened by Leeman Bros (LeemanBros) - Monday, 03 January 2011, 19:29 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Thursday, 01 December 2011, 04:39 GMT+2
Task Type Bugs
Category Codecs
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

In regards to this post: http://forums.rockbox.org/index.php/topic,26888.0.html


Single OGG file from the entire folder - 10 mb
http://www.fileserve.com/file/pFJVdXz


Entire Folder directory - 141.29 mb
http://www.fileserve.com/file/Q6jDcjb
This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Thursday, 01 December 2011, 04:39 GMT+2
Reason for closing:  Accepted
Comment by MichaelGiacomelli (saratoga) - Monday, 03 January 2011, 22:18 GMT+2
The first file is probably corrupted. VLC simply refuses to play it and seems unable to parse its header (gives wrong track length). ffmpeg does play the file however. Looking at the metadata its got a huge PNG file stuck in the Vorbis tags as a "comment" that none of my programs can understand. You could try removing that and see if that fixes your file.
Comment by Magnus Holmgren (learman) - Saturday, 08 January 2011, 09:43 GMT+2
The Ogg layer tries to read the entire comment packet into memory, which fails due to the large embedded album art (Foobar2000 can display it, by the way).
Comment by Nils Wallménius (nls) - Saturday, 08 January 2011, 20:18 GMT+2
yeah, the failure playing files with a huge comment packet is known, we could skip that packet entirely to avoid this problem IIUC since we don't use the metadata in the codec anyway.
Comment by Nils Wallménius (nls) - Monday, 03 October 2011, 18:38 GMT+2
Here's a patch that hacks around the huge comment packet problem and should let such files play fine, it works for the one such file i have. It would be interesting to hear if it also works for others.
   tremor_skip_comments_hack_9.diff (7.1 KiB) 
 apps/codecs/libtremor/framing.c    |   10 ++++----
 apps/codecs/libtremor/info.c       |    8 ++++--
 apps/codecs/libtremor/vorbisfile.c |   45 ++++++++++++++++++++++++++++---------
 apps/codecs/libtremor/ogg.h        |    4 ++-
 4 files changed, 50 insertions(+), 17 deletions(-)

Comment by Nils Wallménius (nls) - Saturday, 08 October 2011, 12:10 GMT+2
committed the patch

Loading...