Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11858 - Several *.rm / *.ra files do not play anymore

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Tuesday, 04 January 2011, 08:39 GMT+2
Last edited by Andree Buschmann (Buschel) - Sunday, 09 January 2011, 22:33 GMT+2
Task Type Bugs
Category Codecs
Status Closed
Assigned To Andree Buschmann (Buschel)
Player Type All players
Severity Medium
Priority Normal
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The files cook_mono_64.ra, cook_stereo_64.ra (from http://download.rockbox.org/test_files/) and FUN_RM_132.rm (from http://samples.mplayerhq.hu/real/AC-atrc/) do not play anymore. This is with r28960.
This task depends upon

Closed by  Andree Buschmann (Buschel)
Sunday, 09 January 2011, 22:33 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Fixed with r29015.
Comment by Andree Buschmann (Buschel) - Tuesday, 04 January 2011, 12:54 GMT+2
Maybe connected to r28937?
Comment by MichaelGiacomelli (saratoga) - Tuesday, 04 January 2011, 18:05 GMT+2
cook_stereo64 works for me, but mono_64 does not. I'm using r28927.

My guess is that I broke this:

http://svn.rockbox.org/viewvc.cgi/trunk/apps/metadata/rm.c?r1=28788&r2=28787&pathrev=28788

I'll try and make time to look into this later this week.
Comment by Andree Buschmann (Buschel) - Wednesday, 05 January 2011, 19:43 GMT+2
Using r28936 cook_stereo_64, cook_mono_64 and FUN_RM_132.rm work again.
Comment by Andree Buschmann (Buschel) - Friday, 07 January 2011, 21:54 GMT+2
The files from above contain at least 2 media properties header/blocks. The first block contains the expected ".ra" (or the unsupported "LSD:"), the second block contains other metadata. In svn we abort with error in the second media properties header even though there was a valid first one.

Edit: The attached patch introduces a dedicated "LCD:"-handling (return with error as intended), but will not abort if there is an unknown ID (= happens in the second media properties block).
   rm_v01.patch (1 KiB) 
 apps/metadata/rm.c |   12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

Loading...