Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11888 - Fix Onda VX777 display error without define #USB_BOOT when compile

Attached to Project: Rockbox
Opened by PurlingNayuki (yzflcyq) - Tuesday, 18 January 2011, 09:36 GMT+2
Last edited by Maurus Cuelenaere (mcuelenaere) - Tuesday, 18 January 2011, 13:10 GMT+2
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When I compile Onda VX777 I must define #USB_BOOT in autoconf.h or Rockbox won't display correctly.
But define this will make it unable to boot OF. So I tried to fix this and success.
Tested on VX777 and VX747. Both of them works well.
This patch may also make VX747P work.
   fix-ondavx777-display-without-define-#USB_BOOT.di... (2 KiB) 
 firmware/target/mips/ingenic_jz47xx/onda_vx747/lcd-onda_vx747.c |    8 --------
 1 file changed, 8 deletions(-)

This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Tuesday, 18 January 2011, 13:10 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Should be fixed in r29083.
Comment by Thomas Martitz (kugel.) - Tuesday, 18 January 2011, 09:51 GMT+2
Are there any disadvantages? I wonder why the #ifdef USB_BOOT are there in the first place.
Comment by Maurus Cuelenaere (mcuelenaere) - Tuesday, 18 January 2011, 11:03 GMT+2
USB_BOOT resets and inits the lcd controller, resulting in a white flash when the backlight is on.

Thus I disabled this as the OF bootloader already inits the lcd for us, the ifdef is there for when you boot over usb (then you have to initialize the screen yourself).

Perhaps these changes should be wrapped into an ifndef BOOTLOADER block to make the OF able to boot..
Comment by PurlingNayuki (yzflcyq) - Tuesday, 18 January 2011, 11:07 GMT+2
1. There're only advantages in my test. All functions works well.
2. I don't know why.
Between every #USB_BOOT and #endif is code to initial SLCD.
But another question is why OndaVX747 don't have to #define this.

But at least, this patch make it work. That's enough, I think.
Comment by PurlingNayuki (yzflcyq) - Tuesday, 18 January 2011, 11:09 GMT+2
Maurus Cuelenaere (mcuelenaere):
Maybe. I test it again just now, and prove that it do works well on VX747.
Comment by Maurus Cuelenaere (mcuelenaere) - Tuesday, 18 January 2011, 11:12 GMT+2
Yes, but you said it makes the OF boot without working lcd feedback (which I remember seeing when hacking on the OF support).

Loading...