Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11913 - Move TTS correction expressions out of voice.pl into a separate file

Attached to Project: Rockbox
Opened by Dominik Riebeling (bluebrother) - Saturday, 29 January 2011, 19:47 GMT+2
Last edited by Dominik Riebeling (bluebrother) - Sunday, 23 September 2012, 21:37 GMT+2
Task Type Patches
Category Utils
Status Closed
Assigned To Dominik Riebeling (bluebrother)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The attached patch moves the TTS correction expressions into a separate file tools/voice-corrections.txt and adjusts voice.pl to use that. This will allow it to reuse the correction expressions from other programs as well with Rockbox Utility being an interesting candidate (I have a first version of Rockbox Utility using voice-corrections.txt working, but currently there is too much hard coded to create a useful patch from that).

Since I'm not too familiar with Perl I would appreciate comments if the changes made to voice.pl are done in a sensible way.
   0001-Separate-TTS-correction-expressions-into-sep... (10.8 KiB) 
 b/tools/voice-corrections.txt |   92 ++++++++++++++++++++++++++++
 b/tools/voice.pl              |  138 +++++++++++-------------------------------
 2 files changed, 130 insertions(+), 100 deletions(-)

This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Sunday, 23 September 2012, 21:37 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Has been accepted over a year ago -- r29500.
Comment by Dominik Riebeling (bluebrother) - Saturday, 05 February 2011, 00:06 GMT+2
This patch goes on top of the first one and uses voice-corrections.txt in Rockbox Utility. There are currently a couple of limitations (vendor will get ignored, only implemented for voicefile creation) but unless there are concerns about the approach of the initial patch I see this as potential first use implementation.
   0001-Voicefile-generation-implement-string-correc... (9.5 KiB) 
 b/rbutil/rbutilqt/base/rbsettings.cpp |    1 
 b/rbutil/rbutilqt/base/rbsettings.h   |    1 
 b/rbutil/rbutilqt/base/voicefile.cpp  |   74 +++++++++++++++++++++++++++++++++-
 b/rbutil/rbutilqt/base/voicefile.h    |   13 +++++
 b/rbutil/rbutilqt/configure.cpp       |    4 +
 b/rbutil/rbutilqt/configurefrm.ui     |   15 ++++++
 b/rbutil/rbutilqt/rbutilqt.qrc        |    9 ++--
 7 files changed, 108 insertions(+), 9 deletions(-)

Loading...