Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11918 - Refine audio type detection / handling

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Wednesday, 02 February 2011, 11:46 GMT+2
Last edited by Andree Buschmann (Buschel) - Thursday, 03 February 2011, 09:37 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I find it useful to have more detailed information of the current codec / format available. For example svn does not differ between AAC and AAC-HE or MPC SV7 and MPC SV8. The attached patch introduces two new types AFMT_MP4_AAC_HE and AFMT_MPC_SV8 (AFMT_MPC is replaced with AFMT_MPC_SV7). The detection of those types is added to the dedicated metadata parser.

Additionally those new types need to be handled in the helper function get_codec_base_type() to avoid uneccessary codec re-loads. When I added those new types to this function I found that the recently added ATARI formats needed to be added as well.

In the WPS formats are now displayed as follows:
Musepack SV7 -> "MPCv7"
Musepack SV8 -> "MPCv8"
AAC -> "AAC"
AAC High Efficiency -> "AAC-HE"
   audio_types_v01.patch (6.5 KiB) 
 apps/metadata/mp4.c        |   10 +++++++---
 apps/metadata/mpc.c        |    4 ++++
 apps/metadata.c            |   12 +++++++++---
 apps/metadata.h            |    4 +++-
 apps/codec_thread.c        |   33 +++++++++++++++++++++++++++++++--
 apps/codecs/libm4a/demux.c |    3 ++-
 6 files changed, 56 insertions(+), 10 deletions(-)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Thursday, 03 February 2011, 09:37 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Submitted with r29199.
Comment by Andree Buschmann (Buschel) - Wednesday, 02 February 2011, 17:24 GMT+2
Updated against latest changes.
   audio_types_v02.patch (6.5 KiB) 
 apps/metadata/mp4.c        |   10 +++++++---
 apps/metadata/mpc.c        |    4 ++++
 apps/metadata.c            |   12 +++++++++---
 apps/metadata.h            |    4 +++-
 apps/codec_thread.c        |   33 +++++++++++++++++++++++++++++++--
 apps/codecs/libm4a/demux.c |    3 ++-
 6 files changed, 56 insertions(+), 10 deletions(-)

Loading...