Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11924 - Use separate targets for RaaA devices

Attached to Project: Rockbox
Opened by Dave Chapman (linuxstb) - Wednesday, 09 February 2011, 01:46 GMT+2
Last edited by Dave Chapman (linuxstb) - Friday, 11 February 2011, 20:52 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch changes tools/configure to list the available RaaA targets in the main list of targets, instead of using a generic "Application" option with a follow-up question.

This also uses different target_id values for the different targets. The implication of this (I think) is that separate voice/lang files are required for each RaaA. IMO this is correct as they can potentially differ in the available features.

I'll commit this after it is confirmed I haven't broken anything - I don't have the Android or Maemo SDKs installed yet.
   configure-app-targets-v1.diff (12.7 KiB) 
 tools/configure |  325 +++++++++++++++++++++++++++++++++-----------------------
 1 file changed, 194 insertions(+), 131 deletions(-)

This task depends upon

Closed by  Dave Chapman (linuxstb)
Friday, 11 February 2011, 20:52 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  v4 of patch committed as r29286
Comment by Thomas Jarosch (thomasjfox) - Wednesday, 09 February 2011, 09:39 GMT+2
Hello Dave,

took a quick look at it and it seems fine. I can give it a test run in the evening.

The "debian/rules" CONFIGURE_OPTIONS will break by this change. Should be easy to fix:
Add the pkgconfig call in there and determine the maemo version, too.

Cheers,
Thomas
Comment by Dave Chapman (linuxstb) - Wednesday, 09 February 2011, 21:02 GMT+2
Attached is an updated patch which fixes some issues found, including "make reconf" not working and maemo4cc being incomplete.

   configure-app-targets-v2.diff (15 KiB) 
 tools/configure |  365 +++++++++++++++++++++++++++++++++-----------------------
 1 file changed, 221 insertions(+), 144 deletions(-)

Comment by Dave Chapman (linuxstb) - Wednesday, 09 February 2011, 22:48 GMT+2
More fixes. Revert to the original maemocc function, passing the required maemo version as a parameter.
   configure-app-targets-v3.diff (11.4 KiB) 
 tools/configure |  270 ++++++++++++++++++++++++++++++++------------------------
 1 file changed, 156 insertions(+), 114 deletions(-)

Comment by Dave Chapman (linuxstb) - Thursday, 10 February 2011, 13:37 GMT+2
This patch includes (untested) changes to debian/rules to choose the correct target based on the version of the Maemo SDK activated
   configure-app-targets-v4.diff (12.1 KiB) 
 debian/rules    |    9 +
 tools/configure |  270 ++++++++++++++++++++++++++++++++------------------------
 2 files changed, 164 insertions(+), 115 deletions(-)

Comment by Thomas Jarosch (thomasjfox) - Friday, 11 February 2011, 09:29 GMT+2
Hey Dave,

thanks for the updated patch, I'll give it a test run in the evening.

Thomas
Comment by Thomas Jarosch (thomasjfox) - Friday, 11 February 2011, 20:07 GMT+2
Patch v4 works fine, it builds the binary package out of the box.

I'd say commit it :)

Loading...