Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11933 - Check for external album art if embedded album art fails to load

Attached to Project: Rockbox
Opened by Magnus Holmgren (learman) - Sunday, 13 February 2011, 14:43 GMT+2
Last edited by Magnus Holmgren (learman) - Wednesday, 16 February 2011, 19:07 GMT+2
Task Type Patches
Category Music playback
Status Closed
Assigned To Magnus Holmgren (learman)
Player Type SW-codec
Severity Low
Priority Normal
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When loading an MP3 with embedded album art in JPEG format, Rockbox will not check for external album art if the image can't be decoded (typically because the JPEG is in an unsupported format). This patch fixes that (and moves the album art loading code to a separate function).
   albumart.diff (4.1 KiB) 
 apps/playback.c |  105 +++++++++++++++++++++++++++++---------------------------
 1 file changed, 56 insertions(+), 49 deletions(-)

This task depends upon

Closed by  Magnus Holmgren (learman)
Wednesday, 16 February 2011, 19:07 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r29319.

Loading...