Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11939 - Simplify talk_time_unit()

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Monday, 14 February 2011, 08:24 GMT+2
Last edited by Andree Buschmann (Buschel) - Sunday, 20 February 2011, 16:23 GMT+2
Task Type Patches
Category Language
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Unify variants within talk_time_unit(). In svn there are two variants which are triggered via UNIT_TIME_EXACT or UNIT_TIME.

Example:
"02:45 h" => "2 hours 45" when using UNIT_TIME
"02:45 h" => "2 hours 45 minutes" when using UNIT_TIME_EXACT

After the latest changes UNIT_TIME is only used in one single place. Additionally it was agreed in IRC that the precise form might be better to use for all languages. This patch removes the variant and will always use the precise form.
   talk_simple_v01.patch (2.8 KiB) 
 apps/screens.c         |    2 +-
 apps/menus/main_menu.c |    2 +-
 apps/talk.c            |   12 +++++-------
 apps/talk.h            |    3 +--
 4 files changed, 8 insertions(+), 11 deletions(-)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Sunday, 20 February 2011, 16:23 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Submitted with r29347.

Loading...