Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#11956 - False usage of parse_replaygain() in ID3 metadat parsing

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Monday, 21 February 2011, 22:53 GMT+2
Last edited by Andree Buschmann (Buschel) - Tuesday, 22 February 2011, 08:11 GMT+2
Task Type Bugs
Category ID3 / meta data
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.7.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The ID3 metadata parser does not correctly handle parse_replaygain(). The last parameter of parse_replaygain() is the buffer size which is left to save the string representation of replaygain. The current svn implementation calls parse_replaygain() with the length of the string to be evaluated by parse_replaygain().
Possible error case: It may happen that the left buffer is smaller than needed for the string representation.

I am providing this fix as a patch to have some reviewers and testers before submitting it.

Edit: Fixed some types in the comments.
   tag_v02.patch (1.5 KiB) 
 apps/metadata/id3tags.c |   19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Tuesday, 22 February 2011, 08:11 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Submitted with r29375.

Loading...