Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category ID3 / meta data
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Release 3.7.1
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by Buschel - 2011-02-21
Last edited by Buschel - 2011-02-22

FS#11956 - False usage of parse_replaygain() in ID3 metadat parsing

The ID3 metadata parser does not correctly handle parse_replaygain(). The last parameter of parse_replaygain() is the buffer size which is left to save the string representation of replaygain. The current svn implementation calls parse_replaygain() with the length of the string to be evaluated by parse_replaygain().
Possible error case: It may happen that the left buffer is smaller than needed for the string representation.

I am providing this fix as a patch to have some reviewers and testers before submitting it.

Edit: Fixed some types in the comments.

Closed by  Buschel
2011-02-22 07:11
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

Submitted with r29375.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing