Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12001 - Rockbox USB on ClipV2 conflicts with r29169

Attached to Project: Rockbox
Opened by sideral (sideral) - Wednesday, 09 March 2011, 00:48 GMT+2
Last edited by sideral (sideral) - Monday, 21 March 2011, 20:40 GMT+2
Task Type Bugs
Category Drivers
Status Closed
Assigned To No-one
Player Type Sansa AMSv2
Severity Medium
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Enabling Rockbox USB on the ClipV2 (with attached patch 0001) has been very stable for me recently (since r29146, to be exact). I also do not need the hard-reset workaround from  FS#11664 .

But… for reasons I do not understand, r29169 (AMSv2 SD: Fix card insert lockups in USB mode; by jhMikeS) breaks USB for me, and I had to back this change out. Interestingly, the code in question addresses an SD-card issue, but the ClipV2 does not have an SD-card slot.

The symptom is occasional SCSI errors on my Linux host trying to read certain sectors. fsck.vfat fails with an I/O error attempting to read a high-numbered sector (possibly the MBR backup sector).

For the convenience of users who'd like to try Rockbox USB on the ClipV2, the attached patches enable USB (patch 0001) and revert r29169 (patch 0002).
   0001-Enable-Rockbox-USB-for-ClipV2.patch (0.6 KiB) 
 b/firmware/export/config/sansaclipv2.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

   0002-Revert-AMSv2-SD-Fix-card-insert-lockups-in-U... (6.6 KiB) 
 b/firmware/target/arm/as3525/sd-as3525v2.c |  105 +++++++++++------------------
 1 file changed, 42 insertions(+), 63 deletions(-)

This task depends upon

Closed by  sideral (sideral)
Monday, 21 March 2011, 20:40 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Fixed with r29625
Comment by Michael Sevakis (MikeS) - Wednesday, 09 March 2011, 00:53 GMT+2
As I mentioned, try increasing the retry counts in the SD driver, most notably wait_for_tran_state. You can easily add retry to the main card as well in the thansfer sectors funtion by just always setting it > 0. The infine loops won't work in general and should be considered unsafe. You won't break anything by increasing the counts or allowing the retry on the main sd.

The other option is to make it one way without an external slot and another with it but that's sort of ugly.
Comment by Michael Sevakis (MikeS) - Sunday, 20 March 2011, 21:30 GMT+2
Is the issue actually fixed now after r29625? That would be nice indeed.
Comment by sideral (sideral) - Sunday, 20 March 2011, 22:09 GMT+2
Yes, this appears to fix the issue. Thanks to you and funman!
Comment by Matt M (Chesteta) - Monday, 21 March 2011, 03:22 GMT+2
it works! (with one caveat) I am using a FuzeV2, it works great with my 8gb microsd card; however whenever I turn on rockbox I have to unplug and re-plug in my microsd card for rockbox to recognize it.

I can see/read/write the card in windows 7 though; it is actually faster than it had been (can write at 5 mb/s vs 3mb/s with r29143)
Comment by Matt M (Chesteta) - Monday, 21 March 2011, 03:32 GMT+2
I am only running the first patch (0001) though, since I *thought* that the issue was fixed in r29625, I do not know if that is what is causing the caveat.
Comment by sideral (sideral) - Monday, 21 March 2011, 20:39 GMT+2
Matt,

Yes, running SVN head with only patch 0001 should give you somewhat reliable USB access to your SD media.

The “caveat” (SD card not recognized on boot) is a separate issue that's tracked as  FS#11870 .

Loading...