Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12009 - m4a (iTunes) embedded album art

Attached to Project: Rockbox
Opened by Jason Yu (captainkewl) - Sunday, 13 March 2011, 21:57 GMT+2
Last edited by Andree Buschmann (Buschel) - Tuesday, 15 March 2011, 21:18 GMT+2
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Reads the covr tag and sends data to the id3 embedded art structure.

Wasn't entirely sure how to deal with the file offset when consuming the data. Incrementing the offset like read_mp4_tag does causes a codec failure on target (iPod 5G); worked fine when I either left it alone or returned it to the original position with an additional lseek.
   m4a-covr.diff (1.5 KiB) 
 apps/metadata/mp4.c |   27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Tuesday, 15 March 2011, 21:18 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Submitted with r29591.
Comment by Andree Buschmann (Buschel) - Monday, 14 March 2011, 08:13 GMT+2
Can you please attach such m4a-files (1x png, 1x jpg) for validation?
Comment by Thomas Martitz (kugel.) - Monday, 14 March 2011, 12:18 GMT+2
Seems to work for my test file. I've written AA into it with easytag on linux and rockbox reads and displays the jpg version fine, the png one isn't displayed but doesn't cause horrible failure either.
Comment by Thomas Martitz (kugel.) - Monday, 14 March 2011, 12:45 GMT+2
Looking at taglib, there seems to be metadata in the 16 bytes this patch jumps over (denoting the image time), possibly worth reading in.
Comment by Jason Yu (captainkewl) - Tuesday, 15 March 2011, 03:25 GMT+2
Removed that read/lseek brainfart. The first 16 bytes produced by read_mp4_atom is the tag header (see read_mp4_tag). The png detection is there for forward compatibility...

Some sample m4a files: http://www.leyline.com.br/itunes.html
   m4a-covr-2.diff (1.5 KiB) 
 apps/metadata/mp4.c |   25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Comment by Andree Buschmann (Buschel) - Tuesday, 15 March 2011, 07:49 GMT+2
Works like charm for me with the files I downloaded from the link above and two other files with embedded art that I have available.

Loading...