FS#12014 - LD complained about duplicate symbols(missing "extern")
Opened by Huan Zhang (victorzhang) - Wednesday, 16 March 2011, 17:28 GMT
Last edited by Nils Wallménius (nls) - Saturday, 19 March 2011, 10:16 GMT
@rockbox/apps/plugins/fft/const.h, line 1-10
@rockbox/apps/plugins/goban/display.h, line 41, line 44
@rockbox/apps/plugins/rockboy/rockmacros.h, line 100
Since the keyword "extern" is omitted from the header file, global varibles will have multiple definition.This will cause link error(duplicate symbols),especially for some new version of LD. Generally speaking, if a global variable is going to be used in more than 2 files, it’s better to declare it in the header file(use "extern"), and have ONLY ONE definition in .c file.
Saturday, 19 March 2011, 10:16 GMT
Reason for closing: Accepted
Additional comments about closing: Committed, thanks. I'm still curious why only the mips toolchain cares about this.