Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12024 - List scroll acceleration on non-scrollwheel targets

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Tuesday, 22 March 2011, 08:16 GMT+2
Last edited by Andree Buschmann (Buschel) - Thursday, 24 March 2011, 19:53 GMT+2
Task Type Bugs
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.8
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

A forum post (http://forums.rockbox.org/index.php/topic,27409.0.html) made me check the code and the manual for the settings "List Acceleration Start Delay" and "List Acceleration Speed".

1) There is no manual entry for those settings.
2) The unit for "List Acceleration Start Delay" was UNIT_MS, correct is UNIT_SEC.
3) The implementation used HZ/2 instead of HZ for the delays.
4) The implementation did not double the scroll speed each step.
5) The recognition of a repeated key in action.c uses a too short window (HZ/10). The recognition works more reliable in my tests with HZ/4.
   list_scroll_accel_v01.patch (3.3 KiB) 
 apps/action.c                                |    2 +-
 apps/gui/list.c                              |    8 +++++---
 apps/settings_list.c                         |    2 +-
 manual/configure_rockbox/display_options.tex |   13 +++++++++++++
 4 files changed, 20 insertions(+), 5 deletions(-)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Thursday, 24 March 2011, 19:53 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Kept the linear acceleration but fixed manual and the acceleration in general.
Comment by Thomas Martitz (kugel.) - Tuesday, 22 March 2011, 09:33 GMT+2
Why double the scroll speed? That's nonlinear acceleration, that doesn't sound nice.
Comment by Andree Buschmann (Buschel) - Tuesday, 22 March 2011, 13:33 GMT+2
Depends on how it feels if used. I cannot judge this as I do only have scrollwheel targets and could only test on simulator. Regarding nonlinearity: On scrollwheel targets like the iPod the acceleration is list speed = v^3 (v=rotation speed of wheel) -- for this usecase it feels just right.

Do you have the possibility to test this patch on a target?
Comment by Andree Buschmann (Buschel) - Tuesday, 22 March 2011, 21:41 GMT+2
New version of the patch for the manual.
   manual_accel_v01.patch (1.3 KiB) 
 manual/configure_rockbox/display_options.tex |   13 +++++++++++++
 1 file changed, 13 insertions(+)

Comment by Andree Buschmann (Buschel) - Tuesday, 22 March 2011, 22:16 GMT+2
Submitted apps/settings_list.c and manual/configure_rockbox/display_options.tex as a first step (r29634). Using the correct time base (HZ instead of HZ/2) was 2nd step (r29635).

Loading...