Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12047 - WPS on startup doesn't work on iPod Video

Attached to Project: Rockbox
Opened by Ophir Lojkine (lovasoa) - Thursday, 07 April 2011, 01:27 GMT+2
Last edited by Andree Buschmann (Buschel) - Thursday, 05 May 2011, 08:20 GMT+2
Task Type Bugs
Category User Interface
Status Unconfirmed
Assigned To No-one
Player Type iPod 5G
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

On my iPod video, when I choose to load the WPS on startup (either in the Settings menu or in the alarm menu), it doesn't work. The player stays on the main (root?) screen.

I had to tweak root_menu.c (which I join) to get the alarm to work with the WPS. This is not a patch, but a quick and dirty workaround that I did just to be waked up on time tomorrow...
   root_menu.c (21.3 KiB)
This task depends upon

Comment by Hayden Pearce (St.) - Saturday, 09 April 2011, 12:41 GMT+2
Would it be possible *to* provide a patch, so that we don't have to pull your file, then diff it against svn just to see what it is that you've changed?


[St.]
Comment by Ophir Lojkine (lovasoa) - Saturday, 09 April 2011, 13:58 GMT+2
I'm not on my computer at the moment, so I don't have diff. But I can tell you what I changed :
In the root_menu function, there is the following:
#ifdef HAVE_RTC_ALARM
    if ( rtc_check_alarm_started(true) ) 
    {
        rtc_enable_alarm(false);
        next_screen = GO_TO_WPS;

That I replaced with:
#ifdef HAVE_RTC_ALARM
    if ( rtc_check_alarm_started(true) ) 
    {
        rtc_enable_alarm(false);
        //next_screen = GO_TO_WPS;
        next_screen = GO_TO_PREVIOUS_MUSIC;

I saw in the header file that GO_TO_PREVIOUS_MUSIC was deprecated. But at the moment, it works...
Comment by Jonathan Gordon (jdgordon) - Monday, 15 August 2011, 13:08 GMT+2
Did your playlist finish? if it did then it doesnt really make sense to go into the WPS at startup.

Loading...