Rockbox

Tasklist

FS#12062 - Gapless playback does not work for several mp3 files

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Wednesday, 13 April 2011, 05:48 GMT
Last edited by Andree Buschmann (Buschel) - Wednesday, 13 April 2011, 05:55 GMT
Task Type Bugs
Category ID3 / meta data
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.8.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

In the forums it was reported that gapless playback does not work reliably in svn. Working files could be produced with lame 3.96, older files created with lame 3.90 do not work (see: http://forums.rockbox.org/index.php/topic,27736.0.html).

The gapless information is read during parsing the Xing header. The code had an error in this section as it did not mask the upper 4 bits during a read operation (see the patch below). Therefor gapless did only work with files which had those upper 4 bits set to 0 (= enc_delay was divisible by 16).
This task depends upon

Closed by  Andree Buschmann (Buschel)
Wednesday, 13 April 2011, 05:55 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed in svn (r29708) and v3.8 branch (r29709, after 3.8.1).

Loading...