This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#12069 - Playback rewrite - first stages
Attached to Project:
Rockbox
Opened by Michael Sevakis (MikeS) - Saturday, 16 April 2011, 10:08 GMT+2
Last edited by Michael Sevakis (MikeS) - Wednesday, 27 April 2011, 22:19 GMT+2
Opened by Michael Sevakis (MikeS) - Saturday, 16 April 2011, 10:08 GMT+2
Last edited by Michael Sevakis (MikeS) - Wednesday, 27 April 2011, 22:19 GMT+2
|
DetailsIt's about time to start testing this since it's been working well enough for me now and better than current SVN. It renovates the codec and playback system, addressing whatever bugs are in scope for it and largely confined to directly-related files. It's not all changes I want to make but I almost made my 512KB .patch goal :p. Redoing PCM and some other stuff would be going too far in one felled swoop).
Codec interface is radically changed. NSF codec needs some updating with the metadata parsing if it's to work correctly because it can't poke values into the WPS any longer; the codec's metadata is private to it and playback. I've considered some sort of proper metadata push interface if we do want to do that sort of thing. Anyone who knows about them, give certain codecs a check; however for the most part, the changes are fairly formulaic. There's a #define in playback.h called 'AUDIO_FAST_SKIP_PREVIEW' which enables fast skip preview to keep the displayed track in time with user actions but does use more RAM, so if it's of little benefit on a target (most likely a flash one), it can be disabled for it. 
playback-version-ii.patch
(429.4 KiB)
apps/codecs.c | 96 apps/playlist.c | 43 apps/codecs.h | 67 apps/playlist.h | 3 apps/pcmbuf.c | 55 apps/pcmbuf.h | 10 apps/metadata/nsf.c | 3 apps/plugins/SOURCES | 2 apps/plugins/test_codec.c | 45 apps/gui/wps.c | 41 apps/menus/playback_menu.c | 4 apps/appevents.h | 1 apps/metadata.c | 129 + apps/metadata.h | 7 apps/codec_thread.c | 675 +++--- apps/codec_thread.h | 7 apps/playback.c | 4542 +++++++++++++++++++++++++++++---------------- apps/playback.h | 79 apps/plugin.c | 2 apps/voice_thread.h | 1 apps/plugin.h | 10 apps/buffering.c | 302 ++ apps/buffering.h | 29 apps/codecs/vorbis.c | 74 apps/codecs/codec_crt0.c | 50 apps/codecs/au.c | 80 apps/codecs/ape.c | 54 apps/codecs/aiff.c | 108 - apps/codecs/flac.c | 62 apps/codecs/raac.c | 99 apps/codecs/atrac3_rm.c | 66 apps/codecs/adx.c | 40 apps/codecs/vox.c | 78 apps/codecs/mpa.c | 76 apps/codecs/mpc.c | 76 apps/codecs/speex.c | 61 apps/codecs/mp3_enc.c | 59 apps/codecs/aac.c | 65 apps/codecs/lib/codeclib.c | 27 apps/codecs/lib/codeclib.h | 3 apps/codecs/spc.c | 124 - apps/codecs/tta.c | 61 apps/codecs/alac.c | 199 - apps/codecs/wmapro.c | 68 apps/codecs/wav64.c | 113 - apps/codecs/atrac3_oma.c | 122 - apps/codecs/wmavoice.c | 68 apps/codecs/mod.c | 67 apps/codecs/sid.c | 72 apps/codecs/wavpack_enc.c | 112 - apps/codecs/shorten.c | 40 apps/codecs/wav_enc.c | 54 apps/codecs/asap.c | 32 apps/codecs/wma.c | 77 apps/codecs/a52_rm.c | 77 apps/codecs/nsf.c | 82 apps/codecs/smaf.c | 82 apps/codecs/a52.c | 53 apps/codecs/aiff_enc.c | 54 apps/codecs/cook.c | 63 apps/codecs/wavpack.c | 78 apps/codecs/wav.c | 106 - apps/misc.c | 3 firmware/export/kernel.h | 10 firmware/kernel.c | 213 +- 65 files changed, 5521 insertions(+), 3740 deletions(-) |
This task depends upon
Closed by Michael Sevakis (MikeS)
Wednesday, 27 April 2011, 22:19 GMT+2
Reason for closing: Accepted
Additional comments about closing: Committed in r29785 with a few minor tweaks.
Wednesday, 27 April 2011, 22:19 GMT+2
Reason for closing: Accepted
Additional comments about closing: Committed in r29785 with a few minor tweaks.
FS#12033much worse. Playing the same SPC file twice in a row while the WPS screen is updating will crash my e200v1 every time. I have to let SPC run for a couple seconds before I can safely click the same file from the file browser.ETA: it's not precisely the same patch either
FS#12033, not here.I use .spc a fair amount and am surprised I never noticed such a problem.
Also, adds a left-out line in apps/codecs/atrac3_rm.c that prevented resume from working there.
ETA: last one is all-in-one of the previous files
I'm attempting to test on a simulator, but build fails (H300 sim, under Cygwin, FWIW):
LD vorbis.codec
/home/Steve/rockbox/buildsim/apps/codecs/libcodec.a(codeclib.o): In function `qsort':
/home/Steve/rockbox/apps/codecs/lib/codeclib.c:149: multiple definition of `_codec_main'
/home/Steve/rockbox/buildsim/apps/codecs/vorbis.o:/home/Steve/rockbox/apps/codecs/vorbis.c:108: first defined here
collect2: ld returned 1 exit status
make: *** [/home/Steve/rockbox/buildsim/apps/codecs/vorbis.codec] Error 1
This is with only the last patch (playback-version-ii-5.patch) applied to SVN r29754.
I mean, it's saying codec_main is inside qsort? :p WTF?
ETA: Still I have no idea why you were (or may still be) getting that problem.
warning: weak declaration of 'codec_main' not supported