Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12075 - Add timeout to quickscreen

Attached to Project: Rockbox
Opened by Rob Walker (tenfoot) - Tuesday, 19 April 2011, 22:07 GMT+2
Task Type Patches
Category Settings
Status Unconfirmed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.8.1
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

Following my patch to control line-out on the Fuze via a setting on the quickscreen (FS#12074), I found I kept forgetting to leave the quickscreen. This meant that when I intended to change track, I was actually changing the shuffle / repeat settings etc and had to fiddle around to get back to where I wanted to - not a good idea when driving at >70mph!

The attached patch adds a configurable timeout to the quickscreen so that it returns to the WPS screen if no button is touched within N seconds. 0 (the default) will disable the timeout preserving the existing behaviour.
   0001-Add-timeout-to-quickscreen.patch (4.6 KiB) 
 b/apps/gui/quickscreen.c    |   16 +++++++++++++++-
 b/apps/lang/english.lang    |   34 ++++++++++++++++++++++++++++++++++
 b/apps/menus/display_menu.c |    9 +++++++++
 b/apps/settings.h           |    1 +
 b/apps/settings_list.c      |    3 +++
 5 files changed, 62 insertions(+), 1 deletion(-)

This task depends upon

Comment by Thomas Martitz (kugel.) - Wednesday, 20 April 2011, 12:50 GMT+2
Not sure if it needs to be configurable. 1s or 2 seems good for everyone IMO.
Comment by Jonathan Gordon (jdgordon) - Wednesday, 20 April 2011, 13:12 GMT+2
use TIME_BEFORE() or TIME_AFTER() to do the time checking or your patch wont do what you want it to do.

kugel, are you perhaps forgetting that we absolutly dont allow screens to change without the user knowing? this requires a setting if it has any chance of being accepted (I like the idea)
Comment by Thomas Martitz (kugel.) - Wednesday, 20 April 2011, 13:20 GMT+2
Do you mean we need a setting (just to make the user aware) or that we just just reject this?

EDIT: Forget the above sentence, I didn't read carefully enough.

Anyway, I didn't know about this. It's not on http://www.rockbox.org/wiki/NoDo
Comment by Frank Gevaerts (fg) - Wednesday, 20 April 2011, 13:23 GMT+2
I agree that it needs to be configurable. 1s or 2s may be good for some people, but I'm pretty sure that some other people will find that too fast. As soon as the actual time is configurable, disabling the timeout is trivial.

I haven't looked at the actual patch yet, but does this take voice into account? Breaking off voice halfway reading the first setting wouldn't be very nice.

I like the idea in general, and I suspect that I'll enable it on my players.
Comment by sideral (sideral) - Wednesday, 20 April 2011, 13:23 GMT+2
I'd love to see this in. The timeout should apply to the pitch screen as well.

I suggest to let the timeout be configurable or to set it to the backlight timeout.
Comment by Frank Gevaerts (fg) - Wednesday, 20 April 2011, 13:33 GMT+2
You can't really use the backlight timeout: not all players have a backlight in the first place, and some (especially mono and greyscale) screens are perfectly readable without a backlight which means that a lot of people will have set their backlight to off altogether.
Comment by Steve Bavin (pondlife) - Wednesday, 20 April 2011, 16:02 GMT+2
If this sort of thing is added, it must be optional. If you're not looking at the screen (or are blind), then any kind of timed mode change is not nice. I prefer to know the UI is where I left it.
Comment by Paul Louden (darkkone) - Wednesday, 20 April 2011, 21:58 GMT+2
Every screen could theoretically benefit from the timeout. There've been several requests to have it return to the WPS after a timeout.

Rather than having specific screens have timeouts, why not just have a "Return to WPS after X seconds" option, if music is playing, that will cover pitch, quickscreen, main menu, filetree, etc all with a single setting?
Comment by Martin Sägmüller (dfkt) - Tuesday, 25 October 2011, 16:52 GMT+2
Resynced to 30835.
   fs#12075-0001-Add-timeout-to-quickscreen-30835.di... (3.9 KiB) 
 apps/lang/english.lang    |   34 ++++++++++++++++++++++++++++++++++
 apps/gui/quickscreen.c    |   16 +++++++++++++++-
 apps/settings.h           |    1 +
 apps/menus/display_menu.c |    9 +++++++++
 apps/settings_list.c      |    3 +++
 5 files changed, 62 insertions(+), 1 deletion(-)

Comment by Martin Sägmüller (dfkt) - Friday, 30 March 2012, 12:06 GMT+2
Resynced.
   fs#12075-0001-Add-timeout-to-quickscreen-20120330... (4.1 KiB) 
 b/apps/gui/quickscreen.c    |   16 +++++++++++++++-
 b/apps/lang/english.lang    |   34 ++++++++++++++++++++++++++++++++++
 b/apps/menus/display_menu.c |    9 +++++++++
 b/apps/settings.h           |    1 +
 b/apps/settings_list.c      |    3 +++
 5 files changed, 62 insertions(+), 1 deletion(-)

Loading...