Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12079 - Support for new commands in iap.c

Attached to Project: Rockbox
Opened by Ophir Lojkine (lovasoa) - Monday, 25 April 2011, 01:32 GMT+2
Last edited by Bertrik Sikken (bertrik) - Wednesday, 27 April 2011, 08:25 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is my first consequent patch to rockbox, so I may have done a lot of mistakes, please be indulgent.

This patch implements several new commands in iap.c to support some stuff related to playlists. Basically, this allows me to access quickly my playlists from my iPod dock.
This task depends upon

Closed by  Bertrik Sikken (bertrik)
Wednesday, 27 April 2011, 08:25 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as SVN r29788, thanks!
Comment by Ophir Lojkine (lovasoa) - Monday, 25 April 2011, 01:36 GMT+2
I didn't join the patch...
   iap_playlists.patch (4.7 KiB) 
 apps/iap.c |   99 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 94 insertions(+), 5 deletions(-)

Comment by Bertrik Sikken (bertrik) - Monday, 25 April 2011, 13:43 GMT+2
I cleaned up the patch a bit:
* removed tabs, replaced them by spaces (please read docs/CONTRIBUTING)
* renamed current_item to cur_dbrecord (I think this is more descriptive)
* commented commands according to specification
* fixed calculation of item_offset (bytes not shifted properly)
* fixed conflict with lingo0/cmd6

I'd like to have this reviewed by another rockbox developer with regards to the playlist logic.
   iap_playlists_v2.patch (4.8 KiB) 
 apps/iap.c |   95 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 93 insertions(+), 2 deletions(-)

Comment by Ophir Lojkine (lovasoa) - Monday, 25 April 2011, 15:29 GMT+2
Wow, you have been very fast. You motivated me to uget_playlist_namepdate my patch again.
- I changed get_playlist_name() to avoid buffer overflow,
- added a check to verify that the files returned are actually playlists
- and prevented the remote device to print files extensions

Again, thanks for your interest...
Comment by Ophir Lojkine (lovasoa) - Monday, 25 April 2011, 15:30 GMT+2
Hmmm; Again! I didn't join the patch! It should be possible to edit previous posts!
   iap_playlists_v3.patch (5.8 KiB) 
 apps/iap.c |  117 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 115 insertions(+), 2 deletions(-)

Loading...