Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12083 - Add delay to usb-s3c6400x init to fix usb hang on some ipod classics

Attached to Project: Rockbox
Opened by Nils Wallménius (nls) - Thursday, 28 April 2011, 19:45 GMT+2
Last edited by Nils Wallménius (nls) - Saturday, 19 November 2011, 12:18 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.8.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This fixes usb mode in rb hanging on my classic 120GB. Starting with usb connected still hangs though... does that work on other classics?
   classic_usbfix.diff (0.5 KiB) 
 firmware/target/arm/usb-s3c6400x.c |    1 +
 1 file changed, 1 insertion(+)

This task depends upon

Closed by  Nils Wallménius (nls)
Saturday, 19 November 2011, 12:18 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  This has been comitted
Comment by Nils Wallménius (nls) - Friday, 29 April 2011, 14:20 GMT+2
Slightly better patch that uses udelays instead of delay loops and makes the delays as long as the bootrom uses, also changes the order of a few things to be more similar to the bootrom. The hang when booting with usb connected is still present, it hangs when waiting for GRSTCTL & 1, i think that's unrelated.
   classic_usbfix_v2.diff (0.9 KiB) 
 firmware/target/arm/usb-s3c6400x.c |   13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

Comment by Nils Wallménius (nls) - Sunday, 01 May 2011, 21:01 GMT+2
Changed usb_drv_exit to do the powerdown like the bootrom does and it seems to have fixed the hang on startup, the order of some writes is slightly different, set more bits in ORSTCON and add in delays for good measure.
   classic_usbfix_v3.diff (1.3 KiB) 
 firmware/target/arm/usb-s3c6400x.c |   20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

Comment by Nils Wallménius (nls) - Monday, 02 May 2011, 22:37 GMT+2
2 people reported that this patch caused usb connections to be successfully established less often on their nano2g's so i guess it needs more investigation.

Loading...