- Status Closed
- Percent Complete
- Task Type Patches
- Category Infrastructure → Build environment
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Release 3.8.1
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#12088 - Reduce warnings ('set but not used')
When using “-Wunused-but-set-variable” there occur several warnings when building rockbox. This patch resolves the most of them.
Please review and give feedback – especially to the change to ffmpeg_get_bits.h as this gives the most overall warnings.
Closed by Buschel
2011-05-03 20:30
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2011-05-03 20:30
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Submitted in several changes.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
We don't really have to cast function return value to void when not using them, do we?
Also, not using // would be nice :)
You are of course right for the //'s. That casting to void was intentional, as I like to use this to show that there is a return value that is intentionally not used (maybe an outcome of using Lint for several years). Nevertheless I removed it was well… I am not insisting on it ;)
I removed the change to codecs/lib/ffmpeg_get_bits.h.
Resync against svn.
v05 was submitted with r29805.
Next submit with r29809.
Should fix nearly all residual warnings – except the one from the ffmpeg code.
Edit: Submitted after slight modifications with r29810.