Rockbox

Tasklist

FS#12088 - Reduce warnings ('set but not used')

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Saturday, 30 April 2011, 14:11 GMT
Last edited by Andree Buschmann (Buschel) - Tuesday, 03 May 2011, 20:30 GMT
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Release 3.8.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

When using "-Wunused-but-set-variable" there occur several warnings when building rockbox. This patch resolves the most of them.

Please review and give feedback -- especially to the change to ffmpeg_get_bits.h as this gives the most overall warnings.
This task depends upon

Closed by  Andree Buschmann (Buschel)
Tuesday, 03 May 2011, 20:30 GMT
Reason for closing:  Accepted
Additional comments about closing:  Submitted in several changes.
Comment by Bertrik Sikken (bertrik) - Saturday, 30 April 2011, 14:46 GMT
We don't really have to cast function return value to void when not using them, do we?
Also, not using // would be nice :)
Comment by Andree Buschmann (Buschel) - Saturday, 30 April 2011, 17:29 GMT
You are of course right for the //'s. That casting to void was intentional, as I like to use this to show that there is a return value that is intentionally not used (maybe an outcome of using Lint for several years). Nevertheless I removed it was well... I am not insisting on it ;)
Comment by Andree Buschmann (Buschel) - Saturday, 30 April 2011, 20:51 GMT
I removed the change to codecs/lib/ffmpeg_get_bits.h.
Comment by Andree Buschmann (Buschel) - Sunday, 01 May 2011, 10:01 GMT
Resync against svn.
Comment by Andree Buschmann (Buschel) - Sunday, 01 May 2011, 11:49 GMT
v05 was submitted with r29805.
Comment by Andree Buschmann (Buschel) - Sunday, 01 May 2011, 13:53 GMT
Next submit with r29809.
Comment by Andree Buschmann (Buschel) - Sunday, 01 May 2011, 14:31 GMT
Should fix nearly all residual warnings -- except the one from the ffmpeg code.

Edit: Submitted after slight modifications with r29810.

Loading...