- Status Closed
- Percent Complete
- Task Type Patches
- Category Drivers
- Assigned To No-one
- Operating System Sansa AMSv2
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#12111 - AS3543: Turn off output mixer AGC as done in AMSv1
While AMSv1 targets are set up to disable output mixer AGC, this is not done on AS3543 equipped ones for some reason. The provided patch corrects that.
Available headroom does not seem to be changed in digital audio playback.
Two versions are provided, one for a standard Rockbox and another that includes the “audiophile patch” FS#11304 (some overlap in modified registers there).
Closed by saratoga
2011-07-24 21:57
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2011-07-24 21:57
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Accepted first patch as r30208. Further
discussion for FS#11304 can continue in its task.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
I did some RMAA tests on that patch, against a clean default build - results can be seen here: http://anythingbutipod.com/forum/showpost.php?p=554724&postcount=1337
I tested first patch.
It prevents a change of irregular volume in the music that is very high in mean volume. The patch seems to be surely effective.
I’ve been running with this patch (in my case the second patch) for a few weeks without issues. I think it can be committed safely.