This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#12112 - Move automatic resume submenu to playback settings
Attached to Project:
Rockbox
Opened by Michael Sevakis (MikeS) - Thursday, 12 May 2011, 06:25 GMT+2
Last edited by Michael Sevakis (MikeS) - Saturday, 14 January 2012, 16:59 GMT+2
Opened by Michael Sevakis (MikeS) - Thursday, 12 May 2011, 06:25 GMT+2
Last edited by Michael Sevakis (MikeS) - Saturday, 14 January 2012, 16:59 GMT+2
|
DetailsDoes just what it says - moves the automatic resume submenu out of the general settings submenu over into the playback settings menu! :-)
move-autoresume-menu-to-playback-settings.patch
(5.7 KiB)
apps/menus/playback_menu.c | 71 ++++++++++++++++++++++++++++++++++++++++++++- apps/menus/settings_menu.c | 63 --------------------------------------- 2 files changed, 70 insertions(+), 64 deletions(-) |
This task depends upon
Closed by Michael Sevakis (MikeS)
Saturday, 14 January 2012, 16:59 GMT+2
Reason for closing: Later
Additional comments about closing: Pointless to have open for now
Saturday, 14 January 2012, 16:59 GMT+2
Reason for closing: Later
Additional comments about closing: Pointless to have open for now
JdGordon and I previously agreed on IRC that we should renovate the presentation of the various resume-related options once the autoresume feature set is stable. OK, let's get to work! *cracks knuckles*
Yes, I agree the autoresume menu is somewhat awkwardly placed in the general-settings menu. However, it is not completely illogical either, because it sits next to the bookmarking menu, which offers related functionality.
In my view, just moving autoresume over to the playback settings doesn't improve the situation all that much. The playback menu already is quite crowded and could use some regrouping. One idea is to collect all resume-related options in one “Pause and Resume” submenu, which could be a submenu of the playback settings:
* Pause on headphone unplug
* Autoresume
* Rewind before resume
* Rewind on pause (
FS#11931, which looks like it will be committed soon)* (forgot anything?)
This also taps into the “What's the difference between pause and stop?” discussion, and raises a terminology issue: Right now we denote as “resume” both unpausing as well as restarting a track somewhere in the middle. This creates confusion with the list of options above, because it doesn't make it obvious that “Rewind before resume” applies to stopped tracks, and “Rewind on pause”, on paused tracks.
"What's the difference between pause and stop?"
Well, internally it's quite different and "stop" means playback is not using any resources other than what is statically allocated for it (effectively, you've closed the playback app). "Pause" is but a temporary stop in spitting out PCM samples to the DAC but all resources needed for playback are hot and states of various submodules are in tact. Resuming at an arbitrary time index from "stop" is not even possible for certain formats, esp. ones that have no notion of "offset" such as game music emulators or where, even if time-based resume becomes available, impractical for those certain codecs. Resuming from "stop" is quite a bit more like seeking.
Truely, one could never fully conceal the difference between "pause" and "stop" to the user.
I guess "unpause" is a good way to put it and leave "resume" for restarting from a stopped state or for returing to an interrupted track.
All that reminds me, there needs to be indication a track can even be seeked and UI should somehow indicate that, possibly restricting input.