Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12127 - Add a track ready event to be sure album art and cuesheets are properly recognized

Attached to Project: Rockbox
Opened by Michael Sevakis (MikeS) - Monday, 23 May 2011, 09:27 GMT+2
Last edited by Michael Sevakis (MikeS) - Wednesday, 25 May 2011, 10:39 GMT+2
Task Type Bugs
Category User Interface
Status Closed
Assigned To Michael Sevakis (MikeS)
Player Type SW-codec
Severity Low
Priority High
Reported Version Release 3.8.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

A problem was mentioned in rockbox-dev where album art might not get picked up initially when starting playback (http://www.rockbox.org/mail/archive/rockbox-dev-archive-2011-05/0000.shtml). I can see how the problem can happen and a way to rememdy it, at least for now. This adds an event that is fired when the remaining handles are finished that the UI has to care about, iff the track was only partially loaded at the time the new track event was fired.

Ok, so maybe it'll stay or maybe it won't. Some other strategies are possible in the way things work underneath that could make such an event unneeded but the changes would be somewhat deep.
   add-track-ready-event.patch (2.4 KiB) 
 apps/gui/wps.c   |    5 +++++
 apps/appevents.h |    8 ++++++++
 apps/playback.c  |   11 +++++++++++
 3 files changed, 24 insertions(+)

This task depends upon

Closed by  Michael Sevakis (MikeS)
Wednesday, 25 May 2011, 10:39 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Reporter says this change takes care of the issue. Discuss further in rockbox-dev where the report was first posted if any more discussion is required.
Comment by Magnus Holmgren (learman) - Tuesday, 24 May 2011, 14:17 GMT+2
Made a quick test, for a known problem case, and it worked fine with the patch applied.
Comment by Michael Sevakis (MikeS) - Wednesday, 25 May 2011, 05:03 GMT+2
What is the particular problem case? I have quite a bit of random stuff with embedded AA and whatnot and it never seems to show itself. Why it even works at all the way it is in SVN is a bit strange, stranger than it not working and yet...

Ok, I'll think about commit tonight even if it's somewhat of a workabout for the moment since I've got other stuff in the pipelines I'm not ready to mess up.

Loading...