This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#12153 - Put Elapsed and Offset in PCM buffer frames.
Attached to Project:
Rockbox
Opened by Michael Sevakis (MikeS) - Sunday, 12 June 2011, 01:28 GMT+2
Last edited by Michael Sevakis (MikeS) - Sunday, 28 August 2011, 10:44 GMT+2
Opened by Michael Sevakis (MikeS) - Sunday, 12 June 2011, 01:28 GMT+2
Last edited by Michael Sevakis (MikeS) - Sunday, 28 August 2011, 10:44 GMT+2
|
DetailsHere we slice up PCM frames into about 1/20s chunks. Codecs set elapsed times and offset before the next PCM insert which associates those values with the audio data it subsequently commits to the buffer.
Codecs are modified only minimally so that they set elapsed/offset before outputting anything. Why? * Accurate position reporting of samples, especially when using the time index in an uncoventional way (as a sub-track indicator for instance). * Timing is accurate through track duration regarless of pitch changes. Now, this is still pretty prelimary. There will likely be short time-reporting glitches in the WPS when switching tracks. Crossfade is not properly converted so don't use it here! I don't want to invest too much into the current way of doing mixing to accomodate a new buffer format. I'd like Primarily I put this up early so that videogame music enthusiasts can enjoy the benefits. 
pcmbuf-timestamping-05.patch
(58.7 KiB)
apps/pcmbuf.c | 704 +++++++++++++++++++++++++++---------------------- apps/pcmbuf.h | 5 apps/codec_thread.c | 11 apps/playback.c | 110 ++----- apps/voice_thread.c | 4 apps/codecs/vorbis.c | 3 apps/codecs/flac.c | 4 apps/codecs/aiff.c | 2 apps/codecs/ape.c | 3 apps/codecs/au.c | 2 apps/codecs/adx.c | 7 apps/codecs/vox.c | 2 apps/codecs/mpa.c | 12 apps/codecs/mpc.c | 4 apps/codecs/aac.c | 5 apps/codecs/speex.c | 1 apps/codecs/spc.c | 2 apps/codecs/tta.c | 2 apps/codecs/alac.c | 2 apps/codecs/wmapro.c | 1 apps/codecs/wav64.c | 2 apps/codecs/wmavoice.c | 2 apps/codecs/mod.c | 3 apps/codecs/sid.c | 2 apps/codecs/shorten.c | 3 apps/codecs/wma.c | 3 apps/codecs/a52_rm.c | 1 apps/codecs/smaf.c | 2 apps/codecs/a52.c | 2 apps/codecs/cook.c | 4 apps/codecs/wavpack.c | 2 apps/codecs/wav.c | 2 32 files changed, 506 insertions(+), 408 deletions(-) |
This task depends upon
Closed by Michael Sevakis (MikeS)
Sunday, 28 August 2011, 10:44 GMT+2
Reason for closing: Accepted
Additional comments about closing: r30366 - with acceptable solution to annoying sticky wicket
Sunday, 28 August 2011, 10:44 GMT+2
Reason for closing: Accepted
Additional comments about closing: r30366 - with acceptable solution to annoying sticky wicket
Crossfade now operates. Some subtle differences exist. Manual skips don't have a fade-in delay and the WPS is updated when the fade-in of the new track happens rather than immediately at the beginning of the crossfade. WPS stays in better sync with what is being heard.
One last thing to work on that I haven't yet is progress reporting glitches at track transitions, probably by suppressing updates and reenabling them at the right time.
So, gotta get that one right too.
Edit: Fix revision number