Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12154 - WM8758(iPod Video) driver according to datasheet

Attached to Project: Rockbox
Opened by Seheon Ryu (cpu98) - Sunday, 12 June 2011, 12:29 GMT+2
Last edited by Andree Buschmann (Buschel) - Monday, 20 June 2011, 20:54 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type iPod 5G
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

First patch does no fuctional change.

Added some comments to ease developing and removed nonfunctional features from header.
Whole datasheet is checked throughly.
   wm8758v1.diff (14.1 KiB) 
 firmware/drivers/audio/wm8758.c |    4 
 firmware/export/wm8758.h        |  164 ++++++++++++++++++++--------------------
 2 files changed, 84 insertions(+), 84 deletions(-)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Monday, 20 June 2011, 20:54 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Patches have been submitted with r30024 and r30025. Looking forward to see you working on the WM8975 :-)
Comment by Seheon Ryu (cpu98) - Sunday, 12 June 2011, 13:34 GMT+2
corrected a typo
   00_wm8758_v2.diff (14.1 KiB) 
 firmware/drivers/audio/wm8758.c |    4 
 firmware/export/wm8758.h        |  164 ++++++++++++++++++++--------------------
 2 files changed, 84 insertions(+), 84 deletions(-)

Comment by Seheon Ryu (cpu98) - Sunday, 12 June 2011, 16:12 GMT+2
Now here goes actual modifications.
You can expect better-than-OF quality.

http://imageshack.us/photo/my-images/860/rockbox.png/
   01_wm8758_v2.diff (2.1 KiB) 
 firmware/drivers/audio/wm8758.c |   17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

Comment by Seheon Ryu (cpu98) - Wednesday, 15 June 2011, 16:55 GMT+2
http://img204.imageshack.us/i/rockbox2.png/

Working on v4 now.
v3 has greatly reduced initial pop noise.

Tested with highly sensitive Sennheiser IE8.
Comment by Andree Buschmann (Buschel) - Wednesday, 15 June 2011, 17:38 GMT+2
I just added  FS#10084  as related task (= bug report about popping noise at startup). I will try to shortly test this patch before the weekend and give feedback about the popping noise on my iPod.

Btw, is there any chance you could work on this for the iPod nano 2G as well? ;-) The iPod Video always sounded much better even w/o this patch.
Comment by Seheon Ryu (cpu98) - Wednesday, 15 June 2011, 17:44 GMT+2
Thanks.
v2 doesn't remove popping noise.
I will upload v3 tomorrow.
Once I get this thing done I'll look what I can do for wm8975.
Comment by Andree Buschmann (Buschel) - Wednesday, 15 June 2011, 18:36 GMT+2
Great, I will use the next patch and give feedback then.
Comment by Seheon Ryu (cpu98) - Thursday, 16 June 2011, 14:43 GMT+2
Notable differences against svn

1. Initial popping noise is reduced. (low imp, hi imp)
2. Sound quality better than RetailOS : Lower crosstalk, lower noise floor, lower HDs, lower IMD better SNR.
3. Thermal shutdown enabled to prevent iPod exploding. :)
   00_wm8758_v4_whitespace.diff (5.2 KiB) 
 firmware/drivers/audio/wm8758.c |   39 +++++++++++++++++++--------------------
 1 file changed, 19 insertions(+), 20 deletions(-)

   01_wm8758_v4_sheetmatching.diff (14.7 KiB) 
 firmware/export/wm8758.h        |  179 +++++++++++++++++++++-------------------
 firmware/drivers/audio/wm8758.c |    4 
 2 files changed, 100 insertions(+), 83 deletions(-)

   02_wm8758_v4_antipop+bettersq.diff (3.2 KiB) 
 firmware/drivers/audio/wm8758.c |   48 ++++++++++++++++++++++++++++++----------
 1 file changed, 37 insertions(+), 11 deletions(-)

Comment by MichaelGiacomelli (saratoga) - Thursday, 16 June 2011, 17:25 GMT+2
That looks like an unloaded RMAA test. You should try with a load, either headphones or at least a resistor to get a more realistic result. The output of the Video looks less impressive when its actually doing something :)
Comment by Seheon Ryu (cpu98) - Sunday, 19 June 2011, 07:19 GMT+2
with a real load
http://imageshack.us/photo/my-images/836/loaded.png/
Comment by Andree Buschmann (Buschel) - Sunday, 19 June 2011, 15:26 GMT+2
I just tested your patch (v4) briefly. The popping noise during startup is drastically reduced. I could not hear any difference between svn and patched version when playing music (I didn't expect to, but I wanted to make sure :).

+1 from me
Comment by MichaelGiacomelli (saratoga) - Sunday, 19 June 2011, 23:50 GMT+2
Looks good to me.

Loading...