Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12158 - One menu item in radio not voiced

Attached to Project: Rockbox
Opened by Marek Salaba (salaba) - Tuesday, 14 June 2011, 14:42 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Thursday, 16 June 2011, 15:28 GMT+2
Task Type Bugs
Category FM Tuner
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.8.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Hello.

One menu item "Mode" (LANG_MODE) in radio submenu not voiced, other are voiced on same place. In this item is showing radio mode scan or present and also swithing it by this submenu item. I found that problem is in file \apps\menus\radio_menu.c in this part :

#ifndef FM_MODE
extern int radio_mode;
static char* get_mode_text(int selected_item, void * data, char *buffer)
{
(void)selected_item;
(void)data;
snprintf(buffer, MAX_PATH, "%s %s", str(LANG_MODE),
radio_mode ? str(LANG_PRESET) :
str(LANG_RADIO_SCAN_MODE));
return buffer;
}
static int toggle_radio_mode(void)
{
radio_mode = (radio_mode == RADIO_SCAN_MODE) ?
RADIO_PRESET_MODE : RADIO_SCAN_MODE;
return 0;
}
MENUITEM_FUNCTION_DYNTEXT(radio_mode_item, 0,
toggle_radio_mode, NULL,
get_mode_text, NULL, NULL, NULL, Icon_NOICON);
#endif

Here isn't used ID2P.
Also for LANG_MODE will have add voice string to english.lang.

Please someone correct it.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 16 June 2011, 15:28 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  r30007
Comment by Jonathan Gordon (jdgordon) - Tuesday, 14 June 2011, 17:19 GMT+2
This fixes it, annoingly LANG_MODE isnt voiced currently so unless you fix your language you might get nothing. (I've updated english.lang to deal with this. I dont know if this breaks things)
   radiofix.patch (1.6 KiB) 
 b/apps/lang/english.lang  |    2 +-
 b/apps/menus/radio_menu.c |   15 ++++++++++++++-
 2 files changed, 15 insertions(+), 2 deletions(-)

Comment by Marek Salaba (salaba) - Wednesday, 15 June 2011, 10:32 GMT+2
Hi Jonathan.
Much more thanks for your fast reaction, but I don't any possibility to test your patch - I can test only in daily builds.
Can you commint it and I just immediately test it. If it did not work so this could go back.

Loading...