Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12164 - Fix subtle bug in cook and atrac3_rm

Attached to Project: Rockbox
Opened by Sean Bartell (wtachi) - Wednesday, 22 June 2011, 10:00 GMT+2
Last edited by Andree Buschmann (Buschel) - Friday, 24 June 2011, 10:52 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Cook and atrac3_rm request slightly less data via ci->request_buffer than they actually need: they fail to account for the packet header. The problem will almost never occur in normal Rockbox, but causes loud noises when request_buffer returns exactly the requested size, especially on low-bitrate cook files.
   fix-cook-atrac3_rm.patch (1.2 KiB) 
 b/apps/codecs/atrac3_rm.c |    2 +-
 b/apps/codecs/cook.c      |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Friday, 24 June 2011, 10:52 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Submitted with r30060, thanks for this fix!

Loading...