- Status Closed
- Percent Complete
- Task Type Patches
- Category Infrastructure → Build environment
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#12165 - Speed up genlang with a generated regex
With this change generating all languages takes only two-thirds the
time. It changes the acceptable syntax for target wildcards in language
files, however: instead of a comma-separated list of glob-style
wildcards it requires that it be a comma-separated list of prefix
matches, i.e. the * can only appear at the end of each wildcard, and ?
cannot be used. This does not require any changes to existing language
files as they are all already in this form.
Closed by kugel.
2011-09-08 14:44
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2011-09-08 14:44
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
r30481
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Another problem I spotted with genlang which leads to quite a speedup if fixed.
$BUILD/apps/lang/english.list is some cache file for the english strings. readenglish() is this cache file if it's newer than english.lang. The problem is the cache file is never updated after initial creation, so the fast path in readenglish() is only taken until english.lang is modified. I attach a patch to fix that, resulting in quite a speed up since the the fast path in readenglish() is taken.
Perhaps english.list should be generated via a make rule instead.
BTW, I have some profiling data here:
http://www.alice-dsl.net/simonemartitz/public/genlang-prof-chin/index.html (SVN)
http://www.alice-dsl.net/simonemartitz/public/genlang-prof-chin-torne/index.html (with the first patch)
http://www.alice-dsl.net/simonemartitz/public/genlang-prof-chin-torne-list/index.html (with both patches)
I'll add my +1 to both of these.