Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#12185 - Fix gapless playback for Nero AAC

Attached to Project: Rockbox
Opened by Yusaku_Inui (Yusaku_Inui) - Saturday, 09 July 2011, 10:28 GMT+2
Last edited by Magnus Holmgren (learman) - Sunday, 24 July 2011, 15:06 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch is fix to work gapless playback for AAC encoded by Nero AAC (Ver.1.3.3.0) and FAAC.
   aac.patch (1.2 KiB) 
 apps/codecs/aac.c |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Magnus Holmgren (learman)
Sunday, 24 July 2011, 15:06 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Fixed in r30149.
Comment by Yusaku_Inui (Yusaku_Inui) - Saturday, 09 July 2011, 13:53 GMT+2
Fix compile error.
   aac.patch (1 KiB) 
 apps/codecs/aac.c |   16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

Comment by Magnus Holmgren (learman) - Saturday, 16 July 2011, 10:02 GMT+2
Could you explain the patch a bit, please? To me it looks like it re-uses the lead_trim at the end of the file if no tail_trim has been specified, and that doesn't look right (the MP4 container already allows the last frame to be properly trimmed, so it shouldn't be necessary for FAAC/Nero at least).
Comment by Yusaku_Inui (Yusaku_Inui) - Saturday, 16 July 2011, 16:27 GMT+2
I'm not sure.
But after r29727, unable gapless playback.
So I undid the point of deleted in r29727.

I have tested this file.
This file was encoded by FAAC and Nero 1.3.3.0.
   test1_faac.m4a (418.3 KiB)
   test2_faac.m4a (488.9 KiB)
   test1_nero.m4a (430.9 KiB)
   test2_nero.m4a (473.9 KiB)
Comment by Magnus Holmgren (learman) - Saturday, 16 July 2011, 18:27 GMT+2
Hm, yes, in the decode of test1_nero (using test_codec), there is a small piece of silence. Not much, 0.01s or so, and it is inaudible to me (the test track I used also get some silence, but only 0.003s). Foobar2000 does a good job, so there's room for improvement. There's got to be a better way though...
Comment by Magnus Holmgren (learman) - Sunday, 17 July 2011, 11:44 GMT+2
I see what you mean now. r29727 removed the last frame trimming used by FAAC/Nero files. I'll commit a fix soon.
Comment by Yusaku_Inui (Yusaku_Inui) - Sunday, 17 July 2011, 17:58 GMT+2
r30149 is very nice.
Sounds fine some test files.
Thanks.

Loading...